All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
	Tom Zanussi <tzanussi@gmail.com>
Subject: Re: [PATCH v2 2/3] tracing/filters: Add __field_ext() to TRACE_EVENT
Date: Fri, 07 Aug 2009 10:45:45 +0800	[thread overview]
Message-ID: <4A7B9559.5000003@cn.fujitsu.com> (raw)
In-Reply-To: <alpine.DEB.2.00.0908062242220.2840@gandalf.stny.rr.com>

>>  #define is_signed_type(type)	(((type)(-1)) < 0)
>>  
>> @@ -165,7 +172,7 @@ do {									\
>>  #define __common_field(type, item, is_signed)				\
>>  	ret = trace_define_field(event_call, #type, "common_" #item,	\
>>  				 offsetof(typeof(field.ent), item),	\
>> -				 sizeof(field.ent.item), is_signed);	\
>> +				 sizeof(field.ent.item), is_signed, -1);\
> 
> I think this wants to be FILTER_OTHER?
> 

oops.. I thought I had changed all -1 to FILTER_OTHER..

I guess you're going to fix this manually?


  reply	other threads:[~2009-08-07  2:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-07  2:32 [PATCH v2 0/3] tracing/filters: Support specifying filter hook to a TRACE_EVENT field Li Zefan
2009-08-07  2:33 ` [PATCH v2 1/3] tracing/filters: Add filter_type to struct ftrace_event_field Li Zefan
2009-08-26  7:23   ` [tip:tracing/core] " tip-bot for Li Zefan
2009-08-07  2:33 ` [PATCH v2 2/3] tracing/filters: Add __field_ext() to TRACE_EVENT Li Zefan
2009-08-07  2:43   ` Steven Rostedt
2009-08-07  2:45     ` Li Zefan [this message]
2009-08-07  2:51       ` Steven Rostedt
2009-08-26  7:23   ` [tip:tracing/core] " tip-bot for Li Zefan
2009-08-07  2:33 ` [PATCH v2 3/3] tracing/filters: Support filtering for char * strings Li Zefan
2009-08-26  7:23   ` [tip:tracing/core] " tip-bot for Li Zefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A7B9559.5000003@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=tzanussi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.