All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Gwendal Grignou <gwendal@google.com>
Cc: jgarzik@pobox.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH] When a disk needs to be waken up from sleep, ensure that the command is retried by SCSI EH.
Date: Fri, 07 Aug 2009 17:34:11 +0900	[thread overview]
Message-ID: <4A7BE703.3000004@kernel.org> (raw)
In-Reply-To: <e7510f760908061028o1b005c4wd2552c24fc619d9e@mail.gmail.com>

Gwendal Grignou wrote:
> The explanation did not go through git-send-email:
> 
>  Without this fix, ATA passthrough commands are not resend to the
> drive, and no error is
>  signalled to the caller because:
>  - allowed retry count is 1
>  - ata_eh_qc_complete fill the sense data, so result is valid
>  - sense data is filled with untouched ATA registers.

Would setting ATA_QCFLAG_RETRY achieve the same result?

Thanks.

-- 
tejun

  reply	other threads:[~2009-08-07  8:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-06 17:25 [PATCH] When a disk needs to be waken up from sleep, ensure that the command is retried by SCSI EH Gwendal Grignou
2009-08-06 17:28 ` Gwendal Grignou
2009-08-07  8:34   ` Tejun Heo [this message]
2009-08-07 22:19     ` Gwendal Grignou
2009-08-07 22:26       ` Gwendal Grignou
2009-08-07 22:37         ` Tejun Heo
2009-08-07 23:06           ` Gwendal Grignou
2009-08-07 23:12             ` Tejun Heo
2009-08-07 23:17               ` [PATCH] When a disk wakes " Gwendal Grignou
2009-08-07 23:23                 ` Tejun Heo
2010-04-22 17:43                   ` Gwendal Grignou
2010-04-22 17:48                     ` Tejun Heo
2013-10-02 18:22                       ` Gwendal Grignou
2013-10-07 19:24                         ` [PATCH] When a disk wakes up from sleep, ensure that the command ?is " Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A7BE703.3000004@kernel.org \
    --to=tj@kernel.org \
    --cc=gwendal@google.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.