All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amerigo Wang <amwang@redhat.com>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: akpm@linux-foundation.org, viro@zeniv.linux.org.uk,
	linux-fsdevel@vger.kernel.org, eparis@redhat.com,
	esandeen@redhat.com, eteo@redhat.com
Subject: Re: [patch 12/12] vfs: allow file truncations when both suid and write permissions set
Date: Fri, 07 Aug 2009 17:20:12 +0800	[thread overview]
Message-ID: <4A7BF1CC.1020201@redhat.com> (raw)
In-Reply-To: <878whwuq9k.fsf@devron.myhome.or.jp>

OGAWA Hirofumi wrote:
> I found the SuSv3 says for ftruncate():
>
> Upon successful completion, if fildes refers to a regular file,
> ftruncate() shall mark for update the last data modification and last
> file status change timestamps of the file and the S_ISUID and S_ISGID
> bits of the file mode may be cleared. If the ftruncate() function is
> unsuccessful, the file is unaffected.
>
> And vmtruncate() can return error easily with RLIMIT_FSIZE or
> ->s_maxbytes. So, I think clearing s[ug]id first may be bad behavior
> without good reason.
>   

Hmm, you mean we should clear suid after we do notify_change()?
Good point!

I will update the patch now...

Thanks for your review!


  reply	other threads:[~2009-08-07  9:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-06 23:10 [patch 12/12] vfs: allow file truncations when both suid and write permissions set akpm
2009-08-07  2:32 ` OGAWA Hirofumi
2009-08-07  3:21   ` Amerigo Wang
2009-08-07  4:17     ` OGAWA Hirofumi
2009-08-07  5:49       ` OGAWA Hirofumi
2009-08-07  9:20         ` Amerigo Wang [this message]
2009-08-07 11:06           ` OGAWA Hirofumi
2009-08-07  9:27       ` Amerigo Wang
2009-08-07 11:02         ` OGAWA Hirofumi
2009-08-07 11:25           ` OGAWA Hirofumi
2009-08-10  2:00             ` Amerigo Wang
2009-08-10  4:34               ` OGAWA Hirofumi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A7BF1CC.1020201@redhat.com \
    --to=amwang@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=eparis@redhat.com \
    --cc=esandeen@redhat.com \
    --cc=eteo@redhat.com \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.