From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/1] net: fix vnet_hdr bustage with slirp Date: Sun, 09 Aug 2009 12:53:37 +0300 Message-ID: <4A7E9CA1.5090706@redhat.com> References: <1249634851-24005-1-git-send-email-markmc@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Mark McLoughlin Return-path: Received: from mx2.redhat.com ([66.187.237.31]:43268 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753394AbZHIJrn (ORCPT ); Sun, 9 Aug 2009 05:47:43 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n799liq3013882 for ; Sun, 9 Aug 2009 05:47:44 -0400 In-Reply-To: <1249634851-24005-1-git-send-email-markmc@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/07/2009 11:47 AM, Mark McLoughlin wrote: > slirp has started using VLANClientState::opaque and this has caused the > kvm specific tap_has_vnet_hdr() hack to break because we blindly use > this opaque pointer even if it is not a tap client. > > Add yet another hack to check that we're actually getting called with a > tap client. > > Applied, thanks. > [Needed on stable-0.11 too] > There as well. -- error compiling committee.c: too many arguments to function