From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Update cr8 intercept when APIC/CR8 is changed by userspace. Date: Sun, 09 Aug 2009 16:46:10 +0300 Message-ID: <4A7ED322.60605@redhat.com> References: <20090809121740.GP4764@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx2.redhat.com ([66.187.237.31]:60587 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753553AbZHINkO (ORCPT ); Sun, 9 Aug 2009 09:40:14 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n79DeGbt010860 for ; Sun, 9 Aug 2009 09:40:16 -0400 In-Reply-To: <20090809121740.GP4764@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/09/2009 03:17 PM, Gleb Natapov wrote: > Since on vcpu entry we do it only if apic is enabled we should do > it when TPR is changed while apic is disabled. This happens when windows > resets HW without setting TPR to zero. > > Applied, thanks. > @@ -4412,6 +4414,7 @@ int kvm_arch_vcpu_ioctl_set_sregs(struct kvm_vcpu *vcpu, > vcpu->arch.cr3 = sregs->cr3; > > kvm_set_cr8(vcpu, sregs->cr8); > + update_cr8_intercept(vcpu); > > mmu_reset_needed |= vcpu->arch.shadow_efer != sregs->efer; > kvm_x86_ops->set_efer(vcpu, sregs->efer); > Already had this bit, so dropped it. -- error compiling committee.c: too many arguments to function