Re: [PATCH 06/10] Move irq routing to its own locking.

[Avi Kivity <avi@redhat.com>]

On 08/09/2009 03:41 PM, Gleb Natapov wrote:
> Signed-off-by: Gleb Natapov<gleb@redhat.com>
> ---
>   include/linux/kvm_host.h |    1 +
>   virt/kvm/irq_comm.c      |    4 ++--
>   virt/kvm/kvm_main.c      |    1 +
>   3 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
> index d573652..ce28cb7 100644
> --- a/include/linux/kvm_host.h
> +++ b/include/linux/kvm_host.h
> @@ -175,6 +175,7 @@ struct kvm {
>   	struct mutex irq_lock;
>   #ifdef CONFIG_HAVE_KVM_IRQCHIP
>   	struct kvm_irq_routing_table *irq_routing;
> +	spinlock_t irq_routing_lock;
>    

Why is this needed?  The irq routing table adds very little contention 
since it is rcu locked.

-- 
error compiling committee.c: too many arguments to function