From: Anthony Liguori <anthony@codemonkey.ws>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: rusty@rustcorp.com.au, qemu-devel@nongnu.org,
virtualization@lists.linux-foundation.org
Subject: [Qemu-devel] Re: [PATCH] qemu/virtio: move features to an inline function
Date: Mon, 10 Aug 2009 14:37:20 -0500 [thread overview]
Message-ID: <4A8076F0.5050700@codemonkey.ws> (raw)
In-Reply-To: <20090810192809.GA16800@redhat.com>
Michael S. Tsirkin wrote:
> devices should have the final say over which virtio features they
> support. E.g. indirect entries may or may not make sense in the context
> of virtio-console. Move the common bits from virtio-pci to an inline
> function and let each device call it.
>
What drove this in vhost?
Normally, the common features are transport features and the devices
should have absolutely no knowledge of transport feature (since they're
transport dependent).
IOW, VIRTIO_RING_F_INDIRECT_DESC is meaningless to virtio-console
because virtio-console has no idea what the ring implementation is that
it sits on top of.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-08-10 19:37 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-10 19:28 [PATCH] qemu/virtio: move features to an inline function Michael S. Tsirkin
2009-08-10 19:28 ` [Qemu-devel] " Michael S. Tsirkin
2009-08-10 19:37 ` Anthony Liguori [this message]
2009-08-10 19:47 ` [Qemu-devel] " Michael S. Tsirkin
2009-08-10 19:47 ` Michael S. Tsirkin
2009-08-10 20:33 ` Anthony Liguori
2009-08-10 20:33 ` Anthony Liguori
2009-08-10 22:19 ` Michael S. Tsirkin
2009-08-10 22:19 ` Michael S. Tsirkin
2009-08-10 22:35 ` Anthony Liguori
2009-08-11 8:48 ` Michael S. Tsirkin
2009-08-11 8:48 ` Michael S. Tsirkin
2009-08-11 13:15 ` Anthony Liguori
2009-08-11 13:15 ` Anthony Liguori
2009-08-11 13:43 ` Michael S. Tsirkin
2009-08-11 13:43 ` Michael S. Tsirkin
2009-08-11 16:08 ` Anthony Liguori
2009-08-11 16:08 ` Anthony Liguori
2009-08-11 16:25 ` Michael S. Tsirkin
2009-08-11 16:25 ` Michael S. Tsirkin
2009-08-12 19:18 ` Anthony Liguori
2009-08-12 19:18 ` Anthony Liguori
2009-08-13 6:15 ` Michael S. Tsirkin
2009-08-13 6:15 ` Michael S. Tsirkin
2009-08-13 9:28 ` Avi Kivity
2009-08-13 9:28 ` Avi Kivity
2009-08-13 9:51 ` Michael S. Tsirkin
2009-08-13 9:51 ` Michael S. Tsirkin
2009-08-10 22:35 ` Anthony Liguori
2009-08-10 19:37 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A8076F0.5050700@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.