From mboxrd@z Thu Jan  1 00:00:00 1970
From: Neil Turton <nturton@solarflare.com>
Subject: Re: Guidance needed
Date: Tue, 11 Aug 2009 09:48:13 +0100
Message-ID: <4A81304D.4000106@solarflare.com>
References: <C6A6022A.11D27%keir.fraser@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C6A6022A.11D27%keir.fraser@eu.citrix.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: Richard Bowser <bowser.richard@gmail.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

Keir Fraser wrote:
> On 10/08/2009 16:48, "Richard Bowser" <bowser.richard@gmail.com> wrote:
>> The ketchup untar function holds this code:
>>     err = os.system("mv linux*/* linux*/.[^.]* ..; rmdir linux*")
>>     if err:
>>         error("ketchup: Unpacking failed: ", err)
>>         sys.exit(-1)
>>
>> I believe the printed 256 above is the hex value passed as "err".
> 
> Er, well it looks like its trying to copy the non-file '..'. That fails and
> so the 'mv' fails and so the following 'rmdir' fails too. I'm not sure why
> it would try to copy '..' as the shell regexp (.[^.]*) appears to explicitly
> exclude it.

The second glob excludes it but the first will match it if dotglob gets
set somehow.

Try inserting '[^.]':
  err = os.system("mv linux*/[^.]* linux*/.[^.]* ..; rmdir linux*")

Cheers, Neil.