From: Patrick McHardy <kaber@trash.net>
To: Oliver Hartkopp <oliver.hartkopp@volkswagen.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Wolfgang Grandegger <wg@grandegger.com>,
dbaryshkov@gmail.com, bugzilla-daemon@bugzilla.kernel.org,
bugme-daemon@bugzilla.kernel.org, "Thuermann, Urs,
Dr. (K-EFFI/I)" <urs.thuermann@volkswagen.de>,
Lothar Wassmann <LW@KARO-electronics.de>,
netdev@vger.kernel.org
Subject: Re: [Bugme-new] [Bug 13954] New: Oops in rtnetlink code when creating can device
Date: Tue, 11 Aug 2009 11:33:35 +0200 [thread overview]
Message-ID: <4A813AEF.7000002@trash.net> (raw)
In-Reply-To: <4A813963.10407@volkswagen.de>
Oliver Hartkopp wrote:
>>> For real hardware CAN devices the netlink interface is only used for the
>>> configuration of already existing interfaces.
>>> From a quick view on the rtnl_newlink() function in net/core/rtnetlink.c
>>> i was not able to find any method to disallow the creation of
>>> interfaces, will say: How can a netlink user provide the information,
>>> that he's not able to create new devices via netlink???
>>>
>>> @Patrick: Do you have an idea for this? Is it a new use-case for netlink
>>> that needs to be implemented?
>>>
>>
>> You could add a ->newlink() function that unconditionally returns
>> an error.
>>
>>
>
> Yes, that fixed it.
>
> I created a can_newlink() function just returning -EINVAL ...
>
> I'll cook a patch and send it on netdev (when it gets online again).
I'd suggest to use EOPNOTSUPP for consistency.
next prev parent reply other threads:[~2009-08-11 12:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-13954-10286@http.bugzilla.kernel.org/>
2009-08-11 4:54 ` [Bugme-new] [Bug 13954] New: Oops in rtnetlink code when creating can device Andrew Morton
2009-08-11 7:52 ` Oliver Hartkopp
2009-08-11 8:22 ` Patrick McHardy
2009-08-11 9:26 ` Oliver Hartkopp
2009-08-11 9:33 ` Patrick McHardy [this message]
2009-08-11 9:36 ` Oliver Hartkopp
2009-08-14 6:23 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A813AEF.7000002@trash.net \
--to=kaber@trash.net \
--cc=LW@KARO-electronics.de \
--cc=akpm@linux-foundation.org \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=bugzilla-daemon@bugzilla.kernel.org \
--cc=dbaryshkov@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=oliver.hartkopp@volkswagen.de \
--cc=urs.thuermann@volkswagen.de \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.