Re: patch for mkfs.ubifs devtable.c increment in dev_table is wrongly interpreted

[Artem Bityutskiy <dedekind1@gmail.com>]

On 08/11/2009 09:45 AM, Artem Bityutskiy wrote:
> On Sun, 2009-08-02 at 16:04 +0200, Daniel Neukomm wrote:
>> patch for mkfs.ubifs devtable.c increment in dev_table is wrongly
>> interpreted
>>
>> with the device table one can add /dev entries to the root file system
>> image.
>> The device table file contains among others the fields minor, start,
>> increment and count.
>> If there is an entry with minor=0 start=0 increment =32 and count=4 the
>> mkfs.ubifs makes
>> 128 device entries, with minor numbers from 0 to 127
>> The correct version makes 4 entries with minor number 0,32,64,96.
>>
>> /dev/mtd c 640 0 0 90 0 0  2 7
>> This gives 14 devices /dev/mtdXX instead of  7 devices.
>> Due to this error mtd_debug info /dev/mtd3 delivers the information of
>> /dev/mtd1 instead of.
>
> Ok, below is how you was supposed to send the patch (without my
> Signed-off-by, of course). I just applied your patch manually (usually
> we use git am for this) and tweaked it.
>
> Please, check that I did not do any mistake. After you have confirmed
> this, I'll push this to the mtd-utils repository.

I've pushed it actually to mtd-utils.git. But please, check it anyway.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)