From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [Qemu-devel] [PATCH] make vga screen_dump use DisplayState properly
Date: Tue, 11 Aug 2009 19:27:21 +0300 [thread overview]
Message-ID: <4A819BE9.1050108@redhat.com> (raw)
In-Reply-To: <4A81917C.3070706@codemonkey.ws>
On 08/11/2009 06:42 PM, Anthony Liguori wrote:
> Stefano Stabellini wrote:
>> Hi all,
>> currently the vga screen_dump code doesn't use the DisplayState
>> interface properly and tries to replace it temporarily while taking the
>> screenshot.
>> A better approach is to register a DisplayChangeListener, call
>> vga_hw_update, and finally write the ppm in the next call from
>> dpy_update.
>>
>> Testing is appreciated.
>
> Does this fix kvm-autotest Avi?
It does. Stefano, thanks for the quick response.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-08-11 16:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-11 15:18 [Qemu-devel] [PATCH] make vga screen_dump use DisplayState properly Stefano Stabellini
2009-08-11 15:42 ` Anthony Liguori
2009-08-11 16:27 ` Avi Kivity [this message]
2009-08-11 16:25 ` Stefano Stabellini
2009-08-12 9:25 ` Alexandre CABROL PERALES
2009-08-12 11:30 ` Stefano Stabellini
2009-08-12 14:36 ` Alexandre CABROL PERALES
2009-08-19 12:21 ` [Qemu-devel] [REGRESSION BUG] Cirrus VGA & Windows NT Alexandre CABROL PERALES
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A819BE9.1050108@redhat.com \
--to=avi@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.