All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zach Brown <zach.brown@oracle.com>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: npiggin@suse.de, Andrew Morton <akpm@linux-foundation.org>,
	Nadia Derbey <Nadia.Derbey@bull.net>,
	Pierre Peiffer <peifferp@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [patch 4/4] ipc: sem optimise simple operations
Date: Tue, 11 Aug 2009 11:23:36 -0700	[thread overview]
Message-ID: <4A81B728.7040200@oracle.com> (raw)
In-Reply-To: <4A81B646.5060301@colorfullife.com>

Manfred Spraul wrote:
> On 08/11/2009 01:09 PM, npiggin@suse.de wrote:
>> Index: linux-2.6/include/linux/sem.h
>> ===================================================================
>> --- linux-2.6.orig/include/linux/sem.h
>> +++ linux-2.6/include/linux/sem.h
>> @@ -86,6 +86,8 @@ struct task_struct;
>>   struct sem {
>>       int    semval;        /* current value */
>>       int    sempid;        /* pid of last operation */
>> +    struct list_head    negv_pending;
>> +    struct list_head    zero_pending;
>>   };
>>    
> struct sem is increased from 8 to 24 bytes.

And larger still with 64bit pointers.

If it's a problem, this can be scaled back.  You can have pointers to
lists and you can have fewer lists.

Hopefully it won't be a problem, though.  We can close our eyes and
pretend that the size of the semaphore sets scale with the size of the
system and that it's such a relatively small consumer of memory that no
one will notice :).

- z

  reply	other threads:[~2009-08-11 18:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-11 11:09 [patch 0/4] ipc sem improvements npiggin
2009-08-11 11:09 ` [patch 1/4] ipc: sem optimise undo list search npiggin
2009-08-16 13:17   ` Manfred Spraul
2009-08-11 11:09 ` [patch 2/4] ipc: sem use list operations npiggin
2009-08-16 13:18   ` Manfred Spraul
2009-08-11 11:09 ` [patch 3/4] ipc: sem preempt improve npiggin
2009-08-16 13:20   ` Manfred Spraul
2009-08-11 11:09 ` [patch 4/4] ipc: sem optimise simple operations npiggin
2009-08-11 18:19   ` Manfred Spraul
2009-08-11 18:23     ` Zach Brown [this message]
2009-08-12  4:07       ` Nick Piggin
2009-08-12 18:35         ` Manfred Spraul
2009-08-14  8:58           ` Nick Piggin
2009-08-14 17:53             ` Manfred Spraul
2009-08-11 20:07   ` Cyrill Gorcunov
2009-08-12  4:48     ` Nick Piggin
2009-08-12  5:43       ` Cyrill Gorcunov
2009-08-14 18:48   ` Manfred Spraul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A81B728.7040200@oracle.com \
    --to=zach.brown@oracle.com \
    --cc=Nadia.Derbey@bull.net \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manfred@colorfullife.com \
    --cc=npiggin@suse.de \
    --cc=peifferp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.