From: "Yang, Xiaowei" <xiaowei.yang@intel.com>
To: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: x86 numa: fix nodes' memory parsing when SRAT table includes future-hotplug memory range
Date: Wed, 12 Aug 2009 17:31:46 +0800 [thread overview]
Message-ID: <4A828C02.2070107@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 542 bytes --]
A node's future-hotplug memory range starts from very high end normally, e.g.
1TB, and is not continuous with its current existing memory range. It should not
be covered by the global variable 'nodes' as it assumes the node's memory is
continuous. Otherwise it can make nodes' memory ranges become very big and
overlapped, and populate_memnodemap() fails.
We can ignore future-hotplug memory range for now. Physical memory hotplug
support in future will handle it.
Signed-off-by: Yang Xiaowei <xiaowei.yang@intel.com>
Thanks,
Xiaowei
[-- Attachment #2: hotplug.patch --]
[-- Type: text/x-patch, Size: 1052 bytes --]
diff -r e35a1c004fc2 xen/arch/x86/srat.c
--- a/xen/arch/x86/srat.c Tue Aug 11 07:36:26 2009 +0100
+++ b/xen/arch/x86/srat.c Wed Aug 12 17:06:48 2009 +0800
@@ -189,10 +189,21 @@
bad_srat();
return;
}
- /* It is fine to add this area to the nodes data it will be used later*/
- if (ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE)
- printk(KERN_INFO "SRAT: hot plug zone found %"PRIx64" - %"PRIx64" \n",
+ if (ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) {
+ if (page_is_ram_type(paddr_to_pfn(start), RAM_TYPE_CONVENTIONAL))
+ printk(KERN_INFO "SRAT: hot-pluggable zone found %"PRIx64" - %"PRIx64" \n",
start, end);
+ else {
+ /* TODO: This range contains no existing memory yet,
+ * and shouldn't be included in nodes' [start, end]. It
+ * will be covered with physical memory hotplug support
+ * in future.
+ */
+ printk(KERN_INFO "SRAT: future hotplug zone found %"PRIx64" - %"PRIx64" \n",
+ start, end);
+ return;
+ }
+ }
i = conflicting_nodes(start, end);
if (i == node) {
printk(KERN_WARNING
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
reply other threads:[~2009-08-12 9:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A828C02.2070107@intel.com \
--to=xiaowei.yang@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.