Re: [PATCH KVM-AUTOTEST 2/2] Convert images to JPEG using PIL instead of an external program

[Avi Kivity <avi@redhat.com>]

On 08/12/2009 03:44 PM, Lucas Meneghel Rodrigues wrote:
>> @@ -110,9 +111,8 @@ def barrier_2(vm, words, params, debug_dir, data_scrdump_filename,
>>               history_scrdump_filename = os.path.join(history_dir,
>>                       "scrdump-step_%s-%s.jpg" % (current_step_num,
>>                                                   time.strftime("%Y%m%d-%H%M%S")))
>> -            kvm_subprocess.run_fg("convert -quality 30 %s %s" %
>> -                                  (scrdump_filename, history_scrdump_filename),
>> -                                  logging.debug, "(convert) ", timeout=30)
>> +            image = PIL.Image.open(scrdump_filename)
>> +            image.save(history_scrdump_filename, format = 'JPEG', quality = 30)
>>      
> Utilities to perform automatic guest installation using step files.
>
> Looks great, but since the python imaging library is an external
> library, we need to handle import failures. We can't guarantee that it
> will allways be installed, so we just degrade functionality gracefully
> in the case is not present.
>    

Why not require it unconditionally?  It's not new and installing it is 
trivial.

-- 
error compiling committee.c: too many arguments to function