From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ruggedcom.com ([204.50.190.93]) by casper.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1MbKuc-0002qP-4H for linux-mtd@lists.infradead.org; Wed, 12 Aug 2009 20:59:15 +0000 Message-ID: <4A832D11.3020802@ruggedcom.com> Date: Wed, 12 Aug 2009 16:58:57 -0400 From: Michael Barkowski MIME-Version: 1.0 To: avorontsov@ru.mvista.com Subject: Re: [PATCH 2/6] mtd: m25p80: Convert to device table matching References: <20090731003957.GA23982@oksana.dev.rtsoft.ru> <20090731004100.GB8371@oksana.dev.rtsoft.ru> <4A832A03.6020507@ruggedcom.com> <20090812205800.GA27074@oksana.dev.rtsoft.ru> In-Reply-To: <20090812205800.GA27074@oksana.dev.rtsoft.ru> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Ben Dooks , David Brownell , Benjamin Herrenschmidt , linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org, Grant Likely , linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org, Jean Delvare , Andrew Morton , David Woodhouse List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Anton Vorontsov wrote: > On Wed, Aug 12, 2009 at 04:45:55PM -0400, Michael Barkowski wrote: >> Hello Anton, >> >> Is m25p_probe now valid with dev.platform_data == NULL, for of platforms? >> >> Then shouldn't you have the following change as well, near the end of >> the function? >> >> - } else if (data->nr_parts) >> + } else if (data && data->nr_parts) >> dev_warn(&spi->dev, "ignoring %d default partitions on %s\n", >> data->nr_parts, data->name); >> >> Or am I misunderstanding something? > > Yeah, you missed this patch: > http://patchwork.kernel.org/patch/38179/ > > > Thanks, > Beautiful - thanks - sorry to interrupt -- Michael Barkowski 905-482-4577 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Barkowski Date: Wed, 12 Aug 2009 20:58:57 +0000 Subject: Re: [lm-sensors] [PATCH 2/6] mtd: m25p80: Convert to device table Message-Id: <4A832D11.3020802@ruggedcom.com> List-Id: References: <20090731003957.GA23982@oksana.dev.rtsoft.ru> <20090731004100.GB8371@oksana.dev.rtsoft.ru> <4A832A03.6020507@ruggedcom.com> <20090812205800.GA27074@oksana.dev.rtsoft.ru> In-Reply-To: <20090812205800.GA27074@oksana.dev.rtsoft.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: avorontsov@ru.mvista.com Cc: Andrew Morton , Ben Dooks , David Brownell , David Woodhouse , Grant Likely , Benjamin Herrenschmidt , Jean Delvare , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org, linuxppc-dev@ozlabs.org Anton Vorontsov wrote: > On Wed, Aug 12, 2009 at 04:45:55PM -0400, Michael Barkowski wrote: >> Hello Anton, >> >> Is m25p_probe now valid with dev.platform_data = NULL, for of platforms? >> >> Then shouldn't you have the following change as well, near the end of >> the function? >> >> - } else if (data->nr_parts) >> + } else if (data && data->nr_parts) >> dev_warn(&spi->dev, "ignoring %d default partitions on %s\n", >> data->nr_parts, data->name); >> >> Or am I misunderstanding something? > > Yeah, you missed this patch: > http://patchwork.kernel.org/patch/38179/ > > > Thanks, > Beautiful - thanks - sorry to interrupt -- Michael Barkowski 905-482-4577 _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 97625B7B5C for ; Thu, 13 Aug 2009 06:58:59 +1000 (EST) Received: from mail.ruggedcom.com (mail.ruggedcom.com [204.50.190.93]) by ozlabs.org (Postfix) with ESMTP id 13DBBDDD01 for ; Thu, 13 Aug 2009 06:58:58 +1000 (EST) Message-ID: <4A832D11.3020802@ruggedcom.com> Date: Wed, 12 Aug 2009 16:58:57 -0400 From: Michael Barkowski MIME-Version: 1.0 To: avorontsov@ru.mvista.com Subject: Re: [PATCH 2/6] mtd: m25p80: Convert to device table matching References: <20090731003957.GA23982@oksana.dev.rtsoft.ru> <20090731004100.GB8371@oksana.dev.rtsoft.ru> <4A832A03.6020507@ruggedcom.com> <20090812205800.GA27074@oksana.dev.rtsoft.ru> In-Reply-To: <20090812205800.GA27074@oksana.dev.rtsoft.ru> Content-Type: text/plain; charset=utf-8 Cc: Ben Dooks , David Brownell , linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org, linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org, Jean Delvare , Andrew Morton , David Woodhouse List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Anton Vorontsov wrote: > On Wed, Aug 12, 2009 at 04:45:55PM -0400, Michael Barkowski wrote: >> Hello Anton, >> >> Is m25p_probe now valid with dev.platform_data == NULL, for of platforms? >> >> Then shouldn't you have the following change as well, near the end of >> the function? >> >> - } else if (data->nr_parts) >> + } else if (data && data->nr_parts) >> dev_warn(&spi->dev, "ignoring %d default partitions on %s\n", >> data->nr_parts, data->name); >> >> Or am I misunderstanding something? > > Yeah, you missed this patch: > http://patchwork.kernel.org/patch/38179/ > > > Thanks, > Beautiful - thanks - sorry to interrupt -- Michael Barkowski 905-482-4577 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755165AbZHLVBL (ORCPT ); Wed, 12 Aug 2009 17:01:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755145AbZHLVBK (ORCPT ); Wed, 12 Aug 2009 17:01:10 -0400 Received: from mail.ruggedcom.com ([204.50.190.93]:14574 "EHLO mail.ruggedcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754190AbZHLVBK (ORCPT ); Wed, 12 Aug 2009 17:01:10 -0400 X-Greylist: delayed 911 seconds by postgrey-1.27 at vger.kernel.org; Wed, 12 Aug 2009 17:01:09 EDT Message-ID: <4A832D11.3020802@ruggedcom.com> Date: Wed, 12 Aug 2009 16:58:57 -0400 From: Michael Barkowski User-Agent: Mozilla-Thunderbird 2.0.0.19 (X11/20090103) MIME-Version: 1.0 To: avorontsov@ru.mvista.com CC: Andrew Morton , Ben Dooks , David Brownell , David Woodhouse , Grant Likely , Benjamin Herrenschmidt , Jean Delvare , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org, linuxppc-dev@ozlabs.org Subject: Re: [PATCH 2/6] mtd: m25p80: Convert to device table matching References: <20090731003957.GA23982@oksana.dev.rtsoft.ru> <20090731004100.GB8371@oksana.dev.rtsoft.ru> <4A832A03.6020507@ruggedcom.com> <20090812205800.GA27074@oksana.dev.rtsoft.ru> In-Reply-To: <20090812205800.GA27074@oksana.dev.rtsoft.ru> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 12 Aug 2009 20:59:03.0723 (UTC) FILETIME=[B956D7B0:01CA1B8F] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Anton Vorontsov wrote: > On Wed, Aug 12, 2009 at 04:45:55PM -0400, Michael Barkowski wrote: >> Hello Anton, >> >> Is m25p_probe now valid with dev.platform_data == NULL, for of platforms? >> >> Then shouldn't you have the following change as well, near the end of >> the function? >> >> - } else if (data->nr_parts) >> + } else if (data && data->nr_parts) >> dev_warn(&spi->dev, "ignoring %d default partitions on %s\n", >> data->nr_parts, data->name); >> >> Or am I misunderstanding something? > > Yeah, you missed this patch: > http://patchwork.kernel.org/patch/38179/ > > > Thanks, > Beautiful - thanks - sorry to interrupt -- Michael Barkowski 905-482-4577