From: Larry Finger <Larry.Finger@lwfinger.net>
To: Michael Buesch <mb@bu3sch.de>
Cc: bcm43xx-dev@lists.berlios.de,
"Gábor Stefanik" <netrolller.3d@gmail.com>,
"John Linville" <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] b43: Implement RC calibration for rev.0/1 LP-PHYs
Date: Wed, 12 Aug 2009 21:19:42 -0500 [thread overview]
Message-ID: <4A83783E.3000607@lwfinger.net> (raw)
In-Reply-To: <200908122008.29582.mb@bu3sch.de>
Michael Buesch wrote:
> On Wednesday 12 August 2009 19:56:25 Gábor Stefanik wrote:
>> + b43_phy_mask(dev, B43_LPPHY_AFE_DDFS_POINTER_INIT, 0x80FF);
>> + b43_phy_maskset(dev, B43_LPPHY_AFE_DDFS_INCR_INIT, 0xFF80, incr1);
>> + b43_phy_maskset(dev, B43_LPPHY_AFE_DDFS_INCR_INIT, 0x80FF, incr2 << 3);
>
> 3bit shift smells fishy. Did you want 8?
There was a typo in the specs. It now is changed to 8.
>> + for (j = 5; j <= 25; j++) {
>> + lpphy_run_ddfs(dev, 1, 1, j, j, 0);
>
> (Just by guess) Did you really want j,j instead of i,j or something like that?
No, it definitely is j,j.
Larry
prev parent reply other threads:[~2009-08-13 2:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-12 17:56 [PATCH] b43: Implement RC calibration for rev.0/1 LP-PHYs Gábor Stefanik
2009-08-12 18:08 ` Michael Buesch
2009-08-13 2:19 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A83783E.3000607@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=netrolller.3d@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.