From: Brian Haley <brian.haley@hp.com>
To: Joe Perches <joe@perches.com>
Cc: Chuck Lever <chuck.lever@oracle.com>,
Jens Rosenboom <jens@mcbone.net>,
Linux Network Developers <netdev@vger.kernel.org>
Subject: Re: [RFC] ipv6: Change %pI6 format to output compacted addresses?
Date: Thu, 13 Aug 2009 16:24:20 -0400 [thread overview]
Message-ID: <4A847674.5030508@hp.com> (raw)
In-Reply-To: <1250190346.28285.120.camel@Joe-Laptop.home>
Joe Perches wrote:
> I suppose ipv6_addr_v4mapped(addr) could be tested instead
>
> Perhaps this on top of last:
>
> diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> index dd02842..7ce34a7 100644
> --- a/lib/vsprintf.c
> +++ b/lib/vsprintf.c
> @@ -25,6 +25,7 @@
> #include <linux/kallsyms.h>
> #include <linux/uaccess.h>
> #include <linux/ioport.h>
> +#include <net/ipv6.h>
I was trying to avoid this by open-coding the v4mapped check, didn't
know if IPv6-specific headers should be pulled-into this generic
code, even though we're printing IPv6 addresses.
-Brian
next prev parent reply other threads:[~2009-08-13 20:24 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-12 15:39 [RFC] ipv6: Change %pI6 format to output compacted addresses? Jens Rosenboom
2009-08-13 1:33 ` Brian Haley
2009-08-13 10:39 ` Joe Perches
2009-08-13 13:52 ` Jens Rosenboom
2009-08-13 15:07 ` Joe Perches
2009-08-13 14:39 ` Jens Rosenboom
2009-08-13 15:14 ` Chuck Lever
2009-08-13 16:27 ` Brian Haley
2009-08-13 18:10 ` Joe Perches
2009-08-13 18:15 ` Chuck Lever
2009-08-13 18:21 ` Joe Perches
2009-08-13 18:39 ` Chuck Lever
2009-08-13 19:05 ` Joe Perches
2009-08-13 20:24 ` Brian Haley [this message]
2009-08-13 20:28 ` Brian Haley
2009-08-13 20:24 ` Brian Haley
2009-08-13 20:34 ` Joe Perches
2009-08-13 21:02 ` Chuck Lever
2009-08-13 21:13 ` Joe Perches
2009-08-13 23:31 ` David Miller
2009-08-14 6:22 ` Jens Rosenboom
2009-08-14 7:15 ` David Miller
2009-08-14 8:15 ` Jens Rosenboom
2009-08-14 20:12 ` David Miller
2009-08-15 15:24 ` [PATCH] lib/vsprintf.c: Add "%pI6c" - print pointer as compressed ipv6 address Joe Perches
2009-08-16 4:10 ` [RFC PATCH] lib/vsprintf.c: Add struct sockaddr * "%pN<foo>" output Joe Perches
2009-08-19 14:26 ` Chuck Lever
2009-08-19 20:44 ` [RFC PATCH V2] " Joe Perches
2009-08-19 22:20 ` Chuck Lever
2009-08-19 22:36 ` Joe Perches
2009-08-19 23:00 ` Chuck Lever
2009-08-20 4:24 ` Joe Perches
2009-08-20 4:29 ` David Miller
2009-08-17 15:18 ` [PATCH] lib/vsprintf.c: Add "%pI6c" - print pointer as compressed ipv6 address Jens Rosenboom
2009-08-17 22:29 ` [PATCH V2] " Joe Perches
2009-08-18 13:48 ` Jens Rosenboom
2009-08-29 7:20 ` David Miller
2009-08-14 16:26 ` [RFC] ipv6: Change %pI6 format to output compacted addresses? Chuck Lever
2009-08-13 14:18 ` Christoph Hellwig
2009-08-13 14:30 ` Jens Rosenboom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A847674.5030508@hp.com \
--to=brian.haley@hp.com \
--cc=chuck.lever@oracle.com \
--cc=jens@mcbone.net \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.