From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: [pvops-dom0] Adding MCA logging support in pv_ops Date: Thu, 13 Aug 2009 13:55:33 -0700 Message-ID: <4A847DC5.4070604@goop.org> References: <4A7174D3020000780000D350@vpn.id2.novell.com> <4A71D4F8.70804@goop.org> <4A7A0DF7.5040706@goop.org> <4A7C6D67.7090202@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Ke, Liping" Cc: "Kleen, Andi" , Christoph Egger , "xen-devel@lists.xensource.com" , Keir Fraser , Jan Beulich List-Id: xen-devel@lists.xenproject.org On 08/09/09 20:08, Ke, Liping wrote: > Hi, Jeremy > Thanks for the detailed comments. I modified below: > 1. change cs902 to cs: 75ebfa7fbdc > 2. I renamed mce_dom0.c to mce.c and dom0 related message/variables. > 3. use #ifdef CONFIG_XEN_MCE instead. > Thanks a lot! > I pushed this to rebase/dom0/mce, but I haven't merged it with master yet. I changed the way the MCE/MCA feature bits get masked: they're masked in non-dom0 domains like ACPI and APIC, but left as-is otherwise, since the kernel shouldn't care about them unless CONFIG_X86_MCE_INTEL is enabled anyway. J