From: "H. Peter Anvin" <hpa@zytor.com>
To: "Wang, Shane" <shane.wang@intel.com>
Cc: Ingo Molnar <mingo@elte.hu>,
"Cihula, Joseph" <joseph.cihula@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"arjan@linux.intel.com" <arjan@linux.intel.com>,
"andi@firstfloor.org" <andi@firstfloor.org>,
"chrisw@sous-sol.org" <chrisw@sous-sol.org>,
"jmorris@namei.org" <jmorris@namei.org>,
"jbeulich@novell.com" <jbeulich@novell.com>,
"peterm@redhat.com" <peterm@redhat.com>,
"Wei, Gang" <gang.wei@intel.com>
Subject: Re: [PATCH 1/1] intel_txt: to fix build errors of CONFIG_ACPI_SLEEP
Date: Thu, 13 Aug 2009 19:54:19 -0700 [thread overview]
Message-ID: <4A84D1DB.6050304@zytor.com> (raw)
In-Reply-To: <037F493892196B458CD3E193E8EBAD4F01EAB6464E@pdsmsx502.ccr.corp.intel.com>
On 08/13/2009 07:06 PM, Wang, Shane wrote:
> I agree with hpa, considering TXT doesnot depends on acpi sleep.
>
> However, for hpa's patch, set_mac_regions() is for S3 only. I am wondering whether we should enlarge the range of CONFIG_ACPI_SLEEP in set_mac_regions().
> Certainly, for code cleanness, this patch is fine since the assignment
>
>
> takes effect but tboot->mac_regions[] will never be used without S3.
>
OK, that makes it easier. We should just conditionalize the whole thing
then. A lot cleaner than #ifdefing the individual assignments.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2009-08-14 2:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 2:30 [RFC v6][PATCH 0b/4] intel_txt: Intel(R) Trusted Execution Technology support for Linux - Details Joseph Cihula
2009-08-07 7:27 ` Ingo Molnar
2009-08-12 14:53 ` Ingo Molnar
2009-08-12 15:11 ` H. Peter Anvin
2009-08-12 15:42 ` Wang, Shane
2009-08-12 16:28 ` H. Peter Anvin
2009-08-12 16:30 ` Arjan van de Ven
2009-08-12 17:51 ` H. Peter Anvin
2009-08-12 18:20 ` Andi Kleen
2009-08-12 22:37 ` Wang, Shane
2009-08-12 23:07 ` H. Peter Anvin
2009-08-13 3:45 ` Wang, Shane
2009-08-13 6:48 ` Ingo Molnar
2009-08-13 6:19 ` [PATCH 1/1] intel_txt: to fix build errors of CONFIG_ACPI_SLEEP Wang, Shane
2009-08-13 6:46 ` Ingo Molnar
2009-08-13 15:08 ` H. Peter Anvin
2009-08-13 15:46 ` Ingo Molnar
2009-08-13 15:57 ` H. Peter Anvin
2009-08-14 2:06 ` Wang, Shane
2009-08-14 2:54 ` H. Peter Anvin [this message]
2009-08-14 3:04 ` H. Peter Anvin
2009-08-14 8:52 ` Wang, Shane
2009-08-17 8:03 ` [build bug] " Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A84D1DB.6050304@zytor.com \
--to=hpa@zytor.com \
--cc=andi@firstfloor.org \
--cc=arjan@linux.intel.com \
--cc=chrisw@sous-sol.org \
--cc=gang.wei@intel.com \
--cc=jbeulich@novell.com \
--cc=jmorris@namei.org \
--cc=joseph.cihula@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterm@redhat.com \
--cc=shane.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.