From: Roel Kluin <roel.kluin@gmail.com>
To: Francois Romieu <romieu@fr.zoreil.com>,
netdev@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>
Subject: [PATCH] WAN: bit and/or confusion
Date: Fri, 14 Aug 2009 14:51:46 +0200 [thread overview]
Message-ID: <4A855DE2.2000907@gmail.com> (raw)
Fix the tests that check whether Frame* bits are not set
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
// vi drivers/net/wan/dscc4.c +307
#define FrameVfr 0x80
#define FrameRdo 0x40
#define FrameCrc 0x20
#define FrameRab 0x10
diff --git a/drivers/net/wan/dscc4.c b/drivers/net/wan/dscc4.c
index 8face5d..dd3c64a 100644
--- a/drivers/net/wan/dscc4.c
+++ b/drivers/net/wan/dscc4.c
@@ -663,9 +663,9 @@ static inline void dscc4_rx_skb(struct dscc4_dev_priv *dpriv,
} else {
if (skb->data[pkt_len] & FrameRdo)
dev->stats.rx_fifo_errors++;
- else if (!(skb->data[pkt_len] | ~FrameCrc))
+ else if (!(skb->data[pkt_len] & ~FrameCrc))
dev->stats.rx_crc_errors++;
- else if (!(skb->data[pkt_len] | ~(FrameVfr | FrameRab)))
+ else if (!(skb->data[pkt_len] & ~(FrameVfr | FrameRab)))
dev->stats.rx_length_errors++;
else
dev->stats.rx_errors++;
next reply other threads:[~2009-08-14 12:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-14 12:51 Roel Kluin [this message]
2009-08-14 23:32 ` [PATCH] WAN: bit and/or confusion David Miller
2009-08-14 23:36 ` Andrew Morton
2009-08-14 23:41 ` David Miller
2009-08-14 23:58 ` Andrew Morton
2009-08-15 13:41 ` Roel Kluin
2009-08-15 14:13 ` Francois Romieu
2009-08-15 18:46 ` Krzysztof Halasa
2009-08-20 14:04 ` Roel Kluin
2009-08-20 14:25 ` Krzysztof Halasa
2009-08-31 5:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A855DE2.2000907@gmail.com \
--to=roel.kluin@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.