All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Stephane Bakhos <nuitari-kvm@nuitari.net>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] Reordering how tap is initialized
Date: Fri, 14 Aug 2009 08:25:26 -0500	[thread overview]
Message-ID: <4A8565C6.2020507@codemonkey.ws> (raw)
In-Reply-To: <Pine.LNX.4.64.0908140816510.28989@anvil.nuitari.net>

Stephane Bakhos wrote:
> This is my first patch, so I apoligize for breaking any convention.
>
> This patch modifies the order used in net.c for tap initialization.
> It runs the script before the device is opened.

This will break existing scripts that do not rely on explicitly setting 
ifname= and instead rely on tap_open() to allocate a tap device.  In 
fact, this is one of the most common usages.

Regards,

Anthony Liguori

  reply	other threads:[~2009-08-14 13:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-14 12:23 [PATCH] Reordering how tap is initialized Stephane Bakhos
2009-08-14 13:25 ` Anthony Liguori [this message]
2009-08-14 14:01   ` Stephane Bakhos
2009-08-14 16:28     ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A8565C6.2020507@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=kvm@vger.kernel.org \
    --cc=nuitari-kvm@nuitari.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.