Re: patch for compcache recipe

["Ming Chow 周明" <chow.ming@linuxbj.com>]

[-- Attachment #1: Type: text/plain, Size: 3388 bytes --]

Signed-off-by: Zhou Ming <chow.ming@linuxbj.com>

I have renewed the patch looks like:

- added the checksum entry
- use kernel-module-compcache as the package name which results throwing 
out packages like "kernel-module-compcache_0.6pre3-r41.3_beagleboard.ipk"
- use compcache-utils as the tool package name which looks like 
"compcache-utils_0.6pre3-r41.3_beagleboard.ipk"

Ming Chow 周明 wrote:
> Holger Hans Peter Freyther wrote:
>> On Thursday 13 August 2009 21:10:07 Ming Chow 周明 wrote:
>>  
>>> Hi,
>>>
>>> I have tried compcache from code.google.com on beagleboard rev B5 and
>>> n800 for a couple of weeks. It seems helping me getting more usable 
>>> memory.
>>> The patch will add compcache stuff which provides both compcache kernel
>>> modules and managing tool.
>>> Tested with recent oe repo on my boards, more evaluation on various 
>>> real
>>> hardware platforms needed though.
>>> BTW not touched checksum.ini for the tarball yet.
>>>     
>>
>> Hi,
>>
>> the patch looks nice. I have three minor comments.   
> thanks for your kind advices.
>> Would you please add the checksums.ini entry and send the mail with a 
>> Signed-
>> off-by: line?
>>   
> Sure. I added the checksum entry.
>
> BTW. I had experienced some checksum mismatch before. A few packages 
> which just work can not pass checksum matching. I guess it may be 
> caused by hosting or tarball changing without notice. For I am not 
> very clear how the global checksum.ini is maintained. I lazily set 
> OE_ALLOW_INSECURE_DOWNLOADS.
>> I think sending the last two patches (modules_instal target) and not 
>> using gcc directly upstream would make sense? Did you already do that?
>>
>>   
> The modules_install patch is for enable "make modules_install" work 
> when use the Kernel kbuild system which make it kernel independent. 
> Originally, people have to use a load_modules.sh script instead 
> install .kos to lib/modules directory. I think a startup script in 
> /etc/init.d and a setting file in /etc is a next step work, after find 
> out some optimal settings on certain platform/distro combination.
>
> The rzscontrol is compiled to native binary with hardcoded in stock 
> tar ball, change to use ${CCLD} make it work arch independent.
>> This one is on naming. The exmap kernel module is called "kernel-module-
>> exmap", for the sake of consistency you should consider renaming 
>> "compach-
>> modules" to "kernel-module-compcache"? And maybe install rzscontrol 
>> into the compache package too. The reason is that it is not easy to 
>> spot the relationship from compache to the rzscontrol package.
>>
>> z.
>>   
> Good point. I am sorry for mis-naming the module package. Agree with you.
> And which is better do you think:
> mix rzscontrol and kernel modules
> or
> put modules in kernel-module-compcache
> put rzscontrol in kernel-module-compcache-utils (or compcache-utils)
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>>   
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel


[-- Attachment #2: patch-compcache-0.6pre3.diff --]
[-- Type: text/x-patch, Size: 4863 bytes --]

diff --git a/recipes/compcache/compcache/000-compcache-KERNELDIR.patch b/recipes/compcache/compcache/000-compcache-KERNELDIR.patch
new file mode 100644
index 0000000..e80f75b
--- /dev/null
+++ b/recipes/compcache/compcache/000-compcache-KERNELDIR.patch
@@ -0,0 +1,34 @@
+--- compcache-0.6pre3/Makefile.orig	2009-08-14 00:25:45.904934007 +0800
++++ compcache-0.6pre3/Makefile	2009-08-14 00:25:58.404938574 +0800
+@@ -1,17 +1,17 @@
+ EXTRA_CFLAGS	:=	-DCONFIG_BLK_DEV_RAMZSWAP_STATS \
+ 			-g -Wall
+ 
+-ifndef $(KERNEL_BUILD_PATH)
+-	KERNEL_BUILD_PATH="/lib/modules/$(shell uname -r)/build"
++ifndef $(KERNELDIR)
++	KERNELDIR="/lib/modules/$(shell uname -r)/build"
+ endif
+ 
+ obj-m	+=	sub-projects/allocators/xvmalloc-kmod/xvmalloc.o \
+ 		ramzswap.o
+ 
+ all:
+-	make -C $(KERNEL_BUILD_PATH) \
++	make -C $(KERNELDIR) \
+ 		M=$(PWD)/sub-projects/allocators/xvmalloc-kmod modules
+-	make -C $(KERNEL_BUILD_PATH) M=$(PWD) modules
++	make -C $(KERNELDIR) M=$(PWD) modules
+ 	make -C sub-projects/rzscontrol
+ 	@ln -sf sub-projects/allocators/xvmalloc-kmod/xvmalloc.ko
+ 
+@@ -19,7 +19,7 @@
+ 	make -C sub-projects/rzscontrol doc
+ 
+ clean:
+-	make -C $(KERNEL_BUILD_PATH) M=$(PWD) clean
+-	make -C $(KERNEL_BUILD_PATH) M=$(PWD)/sub-projects/allocators/xvmalloc-kmod clean
++	make -C $(KERNELDIR) M=$(PWD) clean
++	make -C $(KERNELDIR) M=$(PWD)/sub-projects/allocators/xvmalloc-kmod clean
+ 	make -C sub-projects/rzscontrol clean
+ 	@rm -rf *.ko
diff --git a/recipes/compcache/compcache/001-compcache-rzscontrol-cross-compile.patch b/recipes/compcache/compcache/001-compcache-rzscontrol-cross-compile.patch
new file mode 100644
index 0000000..8dbb590
--- /dev/null
+++ b/recipes/compcache/compcache/001-compcache-rzscontrol-cross-compile.patch
@@ -0,0 +1,9 @@
+--- compcache-0.6pre3.orig/sub-projects/rzscontrol/Makefile	2009-08-06 23:27:40.000000000 +0800
++++ compcache-0.6pre3/sub-projects/rzscontrol/Makefile	2009-08-14 00:19:38.374938229 +0800
+@@ -1,5 +1,5 @@
+ all:
+-	@gcc -g -Wall -D_GNU_SOURCE rzscontrol.c -o rzscontrol -I ../include -I../..
++	${CCLD} -g -Wall -D_GNU_SOURCE rzscontrol.c -o rzscontrol -I ../include -I../..
+ 
+ doc:
+ 	@xmllint --noout --valid man/rzscontrol.xml
diff --git a/recipes/compcache/compcache/002-compcache-modules-install.patch b/recipes/compcache/compcache/002-compcache-modules-install.patch
new file mode 100644
index 0000000..cf9b9b1
--- /dev/null
+++ b/recipes/compcache/compcache/002-compcache-modules-install.patch
@@ -0,0 +1,13 @@
+--- compcache-0.6pre3/Makefile.orig	2009-08-14 02:33:45.169249060 +0800
++++ compcache-0.6pre3/Makefile	2009-08-14 02:34:15.594938335 +0800
+@@ -13,7 +13,9 @@
+ 		M=$(PWD)/sub-projects/allocators/xvmalloc-kmod modules
+ 	make -C $(KERNELDIR) M=$(PWD) modules
+ 	make -C sub-projects/rzscontrol
+-	@ln -sf sub-projects/allocators/xvmalloc-kmod/xvmalloc.ko
++
++modules_install:
++	make -C $(KERNELDIR) M=$(PWD) modules_install
+ 
+ doc:
+ 	make -C sub-projects/rzscontrol doc
diff --git a/recipes/compcache/compcache_0.6pre3.bb b/recipes/compcache/compcache_0.6pre3.bb
new file mode 100644
index 0000000..ea8772c
--- /dev/null
+++ b/recipes/compcache/compcache_0.6pre3.bb
@@ -0,0 +1,28 @@
+HOMEPAGE = "http://code.google.com/p/compcache"
+DESCRIPTION = "Kernel drivers version 0.6x and related tool for the compcache (compressed in-memory swap device for linux)"
+LICENSE = "GPLv2"
+
+inherit module
+
+SRC_URI = "http://compcache.googlecode.com/files/compcache-${PV}.tar.gz \
+	file://000-compcache-KERNELDIR.patch;patch=1 \
+	file://001-compcache-rzscontrol-cross-compile.patch;patch=1 \
+	file://002-compcache-modules-install.patch;patch=1 \
+	   "
+
+TARGET_CC_ARCH += "${LDFLAGS}"
+
+PACKAGES = "kernel-module-compcache compcache-utils compcache-utils-dbg compcache-utils-doc"
+
+FILES_kernel-module-compcache = ${FILES_compcache}
+FILES_compcache-utils = "${bindir}/rzscontrol"
+FILES_compcache-utils-dbg = "${bindir}/.debug/rzscontrol"
+FILES_compcache-utils-doc = "${mandir}/man1/rzscontrol.1"
+
+do_install_prepend() {
+	mkdir -p ${D}${bindir}
+	mkdir -p ${D}${mandir}/man1
+	install -m 0755 ${S}/sub-projects/rzscontrol/rzscontrol ${D}${bindir}
+	install -m 0644 ${S}/sub-projects/rzscontrol/man/rzscontrol.1 ${D}${mandir}/man1
+}
+
diff --git a/conf/checksums.ini b/conf/checksums.ini
index bc214eb..2fc1abb 100644
--- a/conf/checksums.ini
+++ b/conf/checksums.ini
@@ -28578,3 +28578,7 @@ sha256=f57c4e33eb2cdd87a6c2f01bfa4794340fbe61ea1a1cfc7dac3b6671e1dd22af
 md5=5f7b88ebb2bcd7e8044328482d079661
 sha256=f57c4e33eb2cdd87a6c2f01bfa4794340fbe61ea1a1cfc7dac3b6671e1dd22af
 
+[http://compcache.googlecode.com/files/compcache-0.6pre3.tar.gz]
+md5=532fbc4e6a8ae0670ec15a49484f313f
+sha256=3e54f26665bd1b7ece4e4621a15f82da66a95bafd04286d447be5a596790a7db
+