Re: Spare warnings - wireless drivers

[Dave <kilroyd@googlemail.com>]

Luis R. Rodriguez wrote:
> Orinoco:
> 
>   CHECK   drivers/net/wireless/orinoco/wext.c
> drivers/net/wireless/orinoco/wext.c:1294:9: warning: context imbalance
> in 'orinoco_ioctl_setibssport' - unexpected unlock

Thanks for the heads up.

I've been staring at setibssport for 5 minutes, and can't see the
alleged imbalance. False positive?

I can't see why sparse picked on setibssport either - half the other
functions in that file do exactly the same.


Dave.

---
PS. since it's short, the full function is:

static int orinoco_ioctl_setibssport(struct net_device *dev,
				     struct iw_request_info *info,
				     void *wrqu,
				     char *extra)
{
	struct orinoco_private *priv = ndev_priv(dev);
	int val = *((int *) extra);
	unsigned long flags;

	if (orinoco_lock(priv, &flags) != 0)
		return -EBUSY;

	priv->ibss_port = val ;

	/* Actually update the mode we are using */
	set_port_type(priv);

	orinoco_unlock(priv, &flags);
	return -EINPROGRESS;		/* Call commit handler */
}

... and there's no (un)locking in set_port_type