diff for duplicates of <4A870E11.10705@arcor.de> diff --git a/a/1.txt b/N1/1.txt index f5c12af..10c7a15 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -21,7 +21,7 @@ Julia Lawall schrieb: > > *x = list_entry@p(...) > ... when != x = E -> *if@p1 (x = NULL) S1 else S2 +> *if@p1 (x == NULL) S1 else S2 > // </smpl> > > Signed-off-by: Julia Lawall <julia@diku.dk> @@ -46,10 +46,12 @@ Julia Lawall schrieb: > - if (use_dma_ppb_du) { > - td = udc_get_last_dma_desc(req); > - if (td) { -> - dma_done > - AMD_GETBITS(td->status, +> - dma_done = +> - AMD_GETBITS(td->status, > - UDC_DMA_IN_STS_BS); > - /* don't care DMA done */ -> - req->req.actual > - req->req.length; +> - req->req.actual = +> - req->req.length; > - } > - } else { > - /* assume all bytes transferred */ @@ -60,7 +62,8 @@ Julia Lawall schrieb: > + if (use_dma_ppb_du) { > + td = udc_get_last_dma_desc(req); > + if (td) { -> + dma_done > + AMD_GETBITS(td->status, +> + dma_done = +> + AMD_GETBITS(td->status, > + UDC_DMA_IN_STS_BS); > + /* don't care DMA done */ > req->req.actual = req->req.length; @@ -70,7 +73,7 @@ Julia Lawall schrieb: > + req->req.actual = req->req.length; > + } > -> - if (req->req.actual = req->req.length) { +> - if (req->req.actual == req->req.length) { > - /* complete req */ > - complete_req(ep, req, 0); > - req->dma_going = 0; @@ -84,7 +87,7 @@ Julia Lawall schrieb: > - &dev->regs->ep_irqmsk); > - } > - -> + if (req->req.actual = req->req.length) { +> + if (req->req.actual == req->req.length) { > + /* complete req */ > + complete_req(ep, req, 0); > + req->dma_going = 0; diff --git a/a/content_digest b/N1/content_digest index f04e8d0..5c72de4 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\0Pine.LNX.4.64.0907120943230.17416@ask.diku.dk\0" "From\0Thomas Dahlmann <dahlmann.thomas@arcor.de>\0" - "Subject\0Re: [PATCH 3/3] drivers/usb/gadget: Drop NULL test on list_entry\0" - "Date\0Fri, 14 Aug 2009 19:32:05 +0000\0" + "Subject\0Re: [PATCH 3/3] drivers/usb/gadget: Drop NULL test on list_entry result\0" + "Date\0Sat, 15 Aug 2009 21:35:45 +0200\0" "To\0Julia Lawall <julia@diku.dk>\0" "Cc\0linux-geode@lists.infradead.org" gregkh@suse.de @@ -33,7 +33,7 @@ ">\n" "> *x = list_entry@p(...)\n" "> ... when != x = E\n" - "> *if@p1 (x = NULL) S1 else S2\n" + "> *if@p1 (x == NULL) S1 else S2\n" "> // </smpl>\n" ">\n" "> Signed-off-by: Julia Lawall <julia@diku.dk>\n" @@ -58,10 +58,12 @@ "> -\t\t\t\tif (use_dma_ppb_du) {\n" "> -\t\t\t\t\ttd = udc_get_last_dma_desc(req);\n" "> -\t\t\t\t\tif (td) {\n" - "> -\t\t\t\t\t\tdma_done > -\t\t\t\t\t\t\tAMD_GETBITS(td->status,\n" + "> -\t\t\t\t\t\tdma_done =\n" + "> -\t\t\t\t\t\t\tAMD_GETBITS(td->status,\n" "> -\t\t\t\t\t\t\tUDC_DMA_IN_STS_BS);\n" "> -\t\t\t\t\t\t/* don't care DMA done */\n" - "> -\t\t\t\t\t\treq->req.actual > -\t\t\t\t\t\t\treq->req.length;\n" + "> -\t\t\t\t\t\treq->req.actual =\n" + "> -\t\t\t\t\t\t\treq->req.length;\n" "> -\t\t\t\t\t}\n" "> -\t\t\t\t} else {\n" "> -\t\t\t\t\t/* assume all bytes transferred */\n" @@ -72,7 +74,8 @@ "> +\t\t\tif (use_dma_ppb_du) {\n" "> +\t\t\t\ttd = udc_get_last_dma_desc(req);\n" "> +\t\t\t\tif (td) {\n" - "> +\t\t\t\t\tdma_done > +\t\t\t\t\t\tAMD_GETBITS(td->status,\n" + "> +\t\t\t\t\tdma_done =\n" + "> +\t\t\t\t\t\tAMD_GETBITS(td->status,\n" "> +\t\t\t\t\t\tUDC_DMA_IN_STS_BS);\n" "> +\t\t\t\t\t/* don't care DMA done */\n" "> \t\t\t\t\treq->req.actual = req->req.length;\n" @@ -82,7 +85,7 @@ "> +\t\t\t\treq->req.actual = req->req.length;\n" "> +\t\t\t}\n" "> \n" - "> -\t\t\t\tif (req->req.actual = req->req.length) {\n" + "> -\t\t\t\tif (req->req.actual == req->req.length) {\n" "> -\t\t\t\t\t/* complete req */\n" "> -\t\t\t\t\tcomplete_req(ep, req, 0);\n" "> -\t\t\t\t\treq->dma_going = 0;\n" @@ -96,7 +99,7 @@ "> -\t\t\t\t\t\t\t&dev->regs->ep_irqmsk);\n" "> -\t\t\t\t\t}\n" "> -\n" - "> +\t\t\tif (req->req.actual = req->req.length) {\n" + "> +\t\t\tif (req->req.actual == req->req.length) {\n" "> +\t\t\t\t/* complete req */\n" "> +\t\t\t\tcomplete_req(ep, req, 0);\n" "> +\t\t\t\treq->dma_going = 0;\n" @@ -111,4 +114,4 @@ "> \t\t}\n" > -e04eca8c9d683b6284668c1a00a4c124e220aec4778594394333c9d696d455e6 +a00a1d5a218541acb13d7be2a75e697bf70d5ac2bb8318bc60bcc90ae593359f
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.