From: Avi Kivity <avi@redhat.com>
To: Mohammed Gamal <m.gamal005@gmail.com>
Cc: KVM list <kvm@vger.kernel.org>
Subject: Re: [PATCH] x86 emulator: Add 'push es' instruction (opcode 0x06)
Date: Sun, 16 Aug 2009 11:42:55 +0300 [thread overview]
Message-ID: <4A87C68F.2080404@redhat.com> (raw)
In-Reply-To: <20090816010921.GA22103@mohd-laptop>
On 08/16/2009 04:09 AM, Mohammed Gamal wrote:
>
> +static void emulate_push_sreg(struct x86_emulate_ctxt *ctxt, int seg)
> +{
> + struct decode_cache *c =&ctxt->decode;
> + c->src.ptr = (unsigned long *)&c->regs[seg];
> + emulate_push(ctxt);
> +}
> +
>
This can't be right. c->regs[] is the general purpose register array,
not the segment registers.
--
error compiling committee.c: too many arguments to function
next parent reply other threads:[~2009-08-16 8:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090816010921.GA22103@mohd-laptop>
2009-08-16 8:42 ` Avi Kivity [this message]
2009-08-17 19:16 [PATCH] x86 emulator: Add 'push es' instruction (opcode 0x06) Mohammed Gamal
-- strict thread matches above, loose matches on Subject: below --
2009-08-16 17:51 Mohammed Gamal
2009-08-17 8:03 ` Avi Kivity
2009-08-17 8:22 ` Mohammed Gamal
2009-08-16 1:07 Mohammed Gamal
2009-08-16 0:53 Mohammed Gamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A87C68F.2080404@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=m.gamal005@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.