From: Kevin Wolf <kwolf@redhat.com>
To: Jamie Lokier <jamie@shareable.org>
Cc: Filip Navara <filip.navara@gmail.com>,
Avi Kivity <avi@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qcow2: Metadata preallocation
Date: Mon, 17 Aug 2009 09:16:09 +0200 [thread overview]
Message-ID: <4A8903B9.3010109@redhat.com> (raw)
In-Reply-To: <20090816164841.GA27122@shareable.org>
Jamie Lokier schrieb:
> Filip Navara wrote:
>> FILE_ATTRIBUTE_SPARSE_FILE? You can't actually set it when
>> opening/creating the file, a separate call to
>> DeviceIoControl/FSCTL_SET_SPARSE is needed.
>
> I see that you increase the file size by writing zeros to the end.
>
> Can't you use the Windows equivalent of unix ftruncate() to extend the
> file instead, after FSCTL_SET_SPARSE?
There actually exists a bdrv_truncate(). I wasn't aware of that. If you
prefer, I can resend the patch with bdrv_truncate instead of a zero write.
Kevin
next prev parent reply other threads:[~2009-08-17 7:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-14 15:00 [Qemu-devel] [PATCH] qcow2: Metadata preallocation Kevin Wolf
2009-08-16 11:58 ` Avi Kivity
2009-08-16 12:12 ` Filip Navara
2009-08-16 16:48 ` Jamie Lokier
2009-08-16 20:28 ` Jamie Lokier
2009-08-17 7:16 ` Kevin Wolf [this message]
2009-08-17 7:11 ` Kevin Wolf
2009-08-17 7:45 ` Avi Kivity
2009-08-17 7:58 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A8903B9.3010109@redhat.com \
--to=kwolf@redhat.com \
--cc=avi@redhat.com \
--cc=filip.navara@gmail.com \
--cc=jamie@shareable.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.