From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mcwdu-0007Yt-0R for qemu-devel@nongnu.org; Mon, 17 Aug 2009 03:28:34 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mcwdp-0007Vi-AB for qemu-devel@nongnu.org; Mon, 17 Aug 2009 03:28:33 -0400 Received: from [199.232.76.173] (port=55575 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mcwdo-0007VV-Uw for qemu-devel@nongnu.org; Mon, 17 Aug 2009 03:28:29 -0400 Received: from mx20.gnu.org ([199.232.41.8]:41394) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mcwdo-00063B-Bm for qemu-devel@nongnu.org; Mon, 17 Aug 2009 03:28:28 -0400 Received: from mx2.redhat.com ([66.187.237.31]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mcwdn-0001SU-4f for qemu-devel@nongnu.org; Mon, 17 Aug 2009 03:28:27 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n7H7SPje021903 for ; Mon, 17 Aug 2009 03:28:25 -0400 Message-ID: <4A890695.5020805@redhat.com> Date: Mon, 17 Aug 2009 09:28:21 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/6] kvm: bios: advertise pci irqs as active high References: <1250252518-29300-1-git-send-email-kraxel@redhat.com> <1250252518-29300-2-git-send-email-kraxel@redhat.com> <20090814131906.GA16448@redhat.com> <4A856DCD.8050704@redhat.com> <20090814165018.GB16448@redhat.com> In-Reply-To: <20090814165018.GB16448@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: qemu-devel@nongnu.org, Avi Kivity On 08/14/09 18:50, Gleb Natapov wrote: > On Fri, Aug 14, 2009 at 03:59:41PM +0200, Gerd Hoffmann wrote: >> On 08/14/09 15:19, Gleb Natapov wrote: >>> On Fri, Aug 14, 2009 at 02:21:53PM +0200, Gerd Hoffmann wrote: >>>> From: Avi Kivity >>>> >>>> now that kvm emulates the ioapic polarity correctly, we must describe >>> kvm yes, but qemu doesn't. It make sense to fix qemu polarity handling >>> in the same series. >> Same series doesn't work. These patches are for the pcbios git tree. >> > We already have pcbios git tree. Cool. Have a look at http://git.qemu.org/. Not yet live. As far I know the plan is to (a) switch from savannah to qemu.org as master tree, (b) import the bios trees as git submodules and (c) hook them into the qemu build process. >> Of course it makes sense to get more features and fixes from kvm >> merged upstream. Feel free to join the party to speed this up ;) >> > kvm implements polarity in in-kernel ioapic, not in qemu one. Ah, ok. upstream qemu probably wants to use the in-kernel ioapic too some day, then we'll need the fixes anyway. But even without that it is saner to have correct ACPI entries IMHO. >> kvm, which is a good thing. Also note that the other patches which >> fix real bugs depend on this one. >> > Can you elaborate which one fixes what bugs? I am not at all against > those patches going into qemu, just curious. AFAIK current bios works > with qemu as is. The patch descriptions are pretty clear ... Patch 4/6 (disallow sharing acpi irq #9) actually fixes some acpi hickups. I've noticed the 'system_powerdown' monitor command started working correctly recently for me, and I think this is this patch (didn't double-check though). cheers, Gerd