All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] qemu-kvm: add compat eventfd
Date: Mon, 17 Aug 2009 11:06:05 +0300	[thread overview]
Message-ID: <4A890F6D.40308@redhat.com> (raw)
In-Reply-To: <20090816142432.GA5572@redhat.com>

On 08/16/2009 05:24 PM, Michael S. Tsirkin wrote:
> Support build on rhel 5.3 where we have syscall for eventfd but not
> userspace wrapper.
>
> Signed-off-by: Michael S. Tsirkin<mst@redhat.com>
> ---
>   compat/sys/eventfd.h |   13 +++++++++++++
>   configure            |    1 +
>   2 files changed, 14 insertions(+), 0 deletions(-)
>   create mode 100644 compat/sys/eventfd.h
>
> diff --git a/compat/sys/eventfd.h b/compat/sys/eventfd.h
> new file mode 100644
> index 0000000..f55d96a
> --- /dev/null
> +++ b/compat/sys/eventfd.h
> @@ -0,0 +1,13 @@
> +#ifndef _COMPAT_SYS_EVENTFD
> +#define _COMPAT_SYS_EVENTFD
> +
> +#include<unistd.h>
> +#include<syscall.h>
> +
> +
> +static inline int eventfd (int count, int flags)
> +{
> +    return syscall(SYS_eventfd, count, flags);
> +}
> +
> +#endif
> diff --git a/configure b/configure
> index 84af8bd..bb2680f 100755
> --- a/configure
> +++ b/configure
> @@ -866,6 +866,7 @@ if test "$kvm" = "yes" ; then
>
>   kvm_cflags="-I$source_path/kvm/include"
>   kvm_cflags="$kvm_cflags -I$source_path/kvm/include/$kvm_arch"
> +kvm_cflags="$kvm_cflags -I$source_path/compat"
>
>    
er, that will override sys/eventfd.h even if it does exist.  We need to prefer the system eventfd.h to ours.


-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2009-08-17  8:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-16 14:24 [PATCH] qemu-kvm: add compat eventfd Michael S. Tsirkin
2009-08-17  8:06 ` Avi Kivity [this message]
2009-08-17  8:13   ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A890F6D.40308@redhat.com \
    --to=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.