Re: [PATCH] glibc 2.9: Remove unnecessary asm/page.h include, not present in recent headers

[Jonathan Cameron <jic23@cam.ac.uk>]

Holger Hans Peter Freyther wrote:
> On Monday 17 August 2009 12:00:33 Jonathan Cameron wrote:
>> Only applies to arm.  The bug may also exist for alpha.
>> The include doesn't appear to be necessary anyway.
>>
>> Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
>> ---
>> First oe patch. Please tell me if I got any of the patch formatting
>> wrong etc. Lots more to follow ;)
> 
> 
> In the future we will ask us why is this patch necessary. 
I'll put more detail in future.

In this particular case though, the patch title gives you most info.
The header doesn't exist so the error message is the somewhat obvious:
../ports/sysdeps/unix/sysv/linux/arm/ioperm.c:48:22: error: asm/page.h: No such file or directory 

So to ease answering 
> the question the patch itself should include the build error you are seeing, a 
> post to a mailinglist or even better a ticket in the glibc bugzilla.

There are reports of related issues with older glibc (2.7)
http://www.mail-archive.com/debian-glibc@lists.debian.org/msg38393.html
http://sourceware.org/ml/crossgcc/2008-05/msg00014.html

Not sure which version this one refers to.
http://sourceware.org/ml/libc-ports/2008-04/msg00005.html
For some reason the problem is still there despite (I think) the last one claiming
a check in to the glibc ports tree well before the 2.9 release.
(not sure if it was a branch or the mainline tree though).

Sorry for the lack of original info, the bug fix seemed so trivial I didn't bother
chasing down other references to it.

Anyhow, just after I sent this out, khem told me (on irc)
that the patch was already there for 2.4.
 
Alternate patch to follow shortly, please ignore original one.

Also the bug no longer exists at the head of the glibc tree.

Thanks,

Jonathan