From: Dirk Behme <dirk.behme@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Adding support for DevKit8000
Date: Mon, 17 Aug 2009 17:16:15 +0200 [thread overview]
Message-ID: <4A89743F.3010109@googlemail.com> (raw)
In-Reply-To: <f67028d40908170645m36d01648p760c69e34215abce@mail.gmail.com>
Frederik Kriewitz wrote:
> Thank you for reviewing my patch.
>
> I've fixed the issues and will submit it again once Jean-Christophe
> updated the mach-types.h.
Please send an official request for this. See
http://lists.denx.de/pipermail/u-boot/2008-September/040553.html
Best regards
Dirk
> On Mon, Aug 17, 2009 at 11:50 AM, Wolfgang Denk<wd@denx.de> wrote:
>>> +#define CONFIG_SYS_MAX_FLASH_SECT 520 /* max number of sectors on */
>>> + /* one chip */
>>> +#define CONFIG_SYS_MAX_FLASH_BANKS 2 /* max number of flash banks */
>>> +#define CONFIG_SYS_MONITOR_LEN SZ_256K /* Reserve 2 sectors */
>>> +
>>> +#define CONFIG_SYS_FLASH_BASE boot_flash_base
>>> +
>>> +/* Monitor at start of flash */
>>> +#define CONFIG_SYS_MONITOR_BASE CONFIG_SYS_FLASH_BASE
>> You seem to have NOR flash, but define NO_FLSH eralier. Is this
>> intentional? What is the rationale behind that?
>
> I don't have NOR flash, just NAND. So NO_FLASH is fine.
>
> I'm was confused about the FLASH stuff too.
> Other OMAP3 Boards have them too and AFAIK none of them has NOR flash.
> e.g. CONFIG_SYS_ENV_SECT_SIZE is defined in several configs but never used.
> I removed them and everything works fine.
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
next prev parent reply other threads:[~2009-08-17 15:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-17 9:18 [U-Boot] [PATCH] Adding support for DevKit8000 Frederik Kriewitz
2009-08-17 9:50 ` Wolfgang Denk
2009-08-17 13:45 ` Frederik Kriewitz
2009-08-17 15:16 ` Dirk Behme [this message]
2009-08-17 18:23 ` Dirk Behme
2009-08-17 15:21 ` Dirk Behme
2009-08-17 17:03 ` Frederik Kriewitz
2009-08-17 17:38 ` Dirk Behme
2009-08-17 20:42 ` Wolfgang Denk
-- strict thread matches above, loose matches on Subject: below --
2009-08-17 23:20 Frederik Kriewitz
2009-08-19 22:19 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-20 3:59 ` Frederik Kriewitz
2009-08-20 5:18 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-20 8:55 ` Frederik Kriewitz
2009-08-20 13:22 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-21 22:15 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89743F.3010109@googlemail.com \
--to=dirk.behme@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.