From: Joshua Jensen <jjensen@workspacewhiz.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Frank Li <lznuaa@gmail.com>,
git@vger.kernel.org, msysgit@googlegroups.com
Subject: Re: [PATCH 05/11] Remove va_copy at MSVC because there are va_copy.
Date: Mon, 17 Aug 2009 12:22:53 -0600 [thread overview]
Message-ID: <4A899FFD.3080607@workspacewhiz.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0908171840450.4991@intel-tinevez-2-302>
----- Original Message -----
From: Johannes Schindelin
Date: 8/17/2009 10:49 AM
> How about this instead?
>
> Work around Microsoft Visual C++ not having va_copy()
>
> In winansi.c, Git wants to know the length of the formatted string
> so it can allocate enough space for it. But Microsoft Visual C++
> does not have va_copy(), so we have to guess
I did not look at the surrounding code, but could Microsoft's C runtime
extension _vscprintf, which returns the number of characters in the
formatted string, be of use here?
Josh
next prev parent reply other threads:[~2009-08-17 18:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-17 16:04 [PATCH 05/11] Remove va_copy at MSVC because there are va_copy Frank Li
2009-08-17 16:49 ` Johannes Schindelin
2009-08-17 18:22 ` Joshua Jensen [this message]
2009-08-17 16:53 ` Paolo Bonzini
2009-08-17 16:56 ` Reece Dunn
2009-08-17 17:02 ` Erik Faye-Lund
2009-08-17 17:26 ` Erik Faye-Lund
2009-08-17 19:46 ` Johannes Schindelin
2009-08-18 5:06 ` Frank Li
2009-08-18 9:54 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A899FFD.3080607@workspacewhiz.com \
--to=jjensen@workspacewhiz.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=lznuaa@gmail.com \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.