From: Karthik R <karthikr@fastmail.fm>
To: git@vger.kernel.org
Subject: [PATCH] GIT_SSH does not override ssh in git-svn
Date: Mon, 17 Aug 2009 16:09:12 -0500 [thread overview]
Message-ID: <4A89C6F8.3010100@fastmail.fm> (raw)
Signed-off-by: Karthik R <karthikr@fastmail.fm>
---
Setting GIT_SSH when using "git svn clone svn+ssh://..." does not
override the
default ssh; SVN_SSH needs to be set instead. Corrected this.
Also, on Windows, SVN_SSH needs to be set with \ escaped
e.g., "C:\\PuTTY\\plink.exe"
See http://code.google.com/p/msysgit/issues/detail?id=305
git-svn.perl | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/git-svn.perl b/git-svn.perl
index b0bfb74..c932b6e 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -21,6 +21,16 @@ $Git::SVN::default_ref_id = $ENV{GIT_SVN_ID} ||
'git-svn';
$Git::SVN::Ra::_log_window_size = 100;
$Git::SVN::_minimize_url = 'unset';
+my $git_ssh_user_set = 1 if defined $ENV{GIT_SSH};
+if ($git_ssh_user_set) {
+ # If GIT_SSH is set, also set SVN_SSH...
+ $ENV{SVN_SSH} = $ENV{GIT_SSH};
+ # ... and escape \s in shell-variable on Windows
+ if ($^O eq 'MSWin32' || $^O eq 'msys') {
+ $ENV{SVN_SSH} =~ s/\\/\\\\/g;
+ }
+}
+
$Git::SVN::Log::TZ = $ENV{TZ};
$ENV{TZ} = 'UTC';
$| = 1; # unbuffer STDOUT
--
1.5.4.3
next reply other threads:[~2009-08-17 21:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-17 21:09 Karthik R [this message]
2009-08-17 21:38 ` [PATCH] GIT_SSH does not override ssh in git-svn Johannes Schindelin
2009-08-17 21:40 ` Junio C Hamano
2009-08-17 22:35 ` Karthik R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89C6F8.3010100@fastmail.fm \
--to=karthikr@fastmail.fm \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.