From: Faidon Liambotis <paravoid@debian.org>
To: Chris Wright <chrisw@sous-sol.org>
Cc: linux-kernel@vger.kernel.org,
Suresh Siddha <suresh.b.siddha@intel.com>,
iommu@lists.linux-foundation.org,
David Woodhouse <David.Woodhouse@intel.com>
Subject: Re: [regression, bisected] fails to boot on Dell Optiplex 760 with VT-d enabled
Date: Tue, 18 Aug 2009 02:22:38 +0300 [thread overview]
Message-ID: <4A89E63E.407@debian.org> (raw)
In-Reply-To: <20090817231156.GJ24885@sequoia.sous-sol.org>
Chris Wright wrote:
> AFAIK, this platform is broken when VT-d is enabled.
> Can you add this patch to a broken kernel and retest?
> Please boot with 'debug' on the kernel command line.
Thanks but David was faster, we've already established that
http://git.infradead.org/iommu-2.6.git/commit/0815565a
which is, as far as I can understand, very similar to your patch, indeed
fixes the issue.
> + if (ver == (u32)-1 || iommu->cap == (u64)-1 || iommu->ecap == (u64)-1) {
As an observation, David's patch is checking if *both* iommu->cap and
iommu->ecap are -1, while yours checks for either. You're also checking
for ver. Obviously, I have no idea which of the two is more correct.
Thanks,
Faidon
next prev parent reply other threads:[~2009-08-17 23:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-17 21:27 [regression, bisected] fails to boot on Dell Optiplex 760 with VT-d enabled Faidon Liambotis
2009-08-17 22:17 ` David Woodhouse
2009-08-17 22:59 ` Faidon Liambotis
2009-08-17 23:11 ` Chris Wright
2009-08-17 23:22 ` Faidon Liambotis [this message]
2009-08-17 23:29 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E63E.407@debian.org \
--to=paravoid@debian.org \
--cc=David.Woodhouse@intel.com \
--cc=chrisw@sous-sol.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.