From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MdVQJ-0005lp-5W for mharc-grub-devel@gnu.org; Tue, 18 Aug 2009 16:36:51 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MdVQH-0005lI-8n for grub-devel@gnu.org; Tue, 18 Aug 2009 16:36:49 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MdVQC-0005jU-Bj for grub-devel@gnu.org; Tue, 18 Aug 2009 16:36:48 -0400 Received: from [199.232.76.173] (port=35677 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MdVQC-0005jN-2K for grub-devel@gnu.org; Tue, 18 Aug 2009 16:36:44 -0400 Received: from vader.rez-gif.supelec.fr ([160.228.154.1]:40132) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MdVQB-0008Bn-HC for grub-devel@gnu.org; Tue, 18 Aug 2009 16:36:43 -0400 Received: from localhost (localhost [127.0.0.1]) by vader.rez-gif.supelec.fr (Postfix) with ESMTP id 252F32C6A81 for ; Tue, 18 Aug 2009 22:36:35 +0200 (CEST) X-Virus-Scanned: amavisd-new at rez-gif.supelec.fr Received: from vader.rez-gif.supelec.fr ([127.0.0.1]) by localhost (vader.rez-gif.supelec.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 25kqbrS0gEtx for ; Tue, 18 Aug 2009 22:36:32 +0200 (CEST) Received: from [127.0.0.1] (duboucher2.rez-gif.supelec.fr [160.228.159.225]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by vader.rez-gif.supelec.fr (Postfix) with ESMTPS id D2E432C6A7F for ; Tue, 18 Aug 2009 22:36:31 +0200 (CEST) Message-ID: <4A8B10CE.9000602@duboucher.eu> Date: Tue, 18 Aug 2009 22:36:30 +0200 From: Duboucher Thomas User-Agent: Thunderbird 2.0.0.22 (Windows/20090605) MIME-Version: 1.0 To: The development of GRUB 2 References: <200908171751.57668.michael@gorven.za.net> <200908180914.53591.michael@gorven.za.net> <4A8AD457.50702@duboucher.eu> <200908182129.51528.michael@gorven.za.net> In-Reply-To: <200908182129.51528.michael@gorven.za.net> X-Enigmail-Version: 0.95.7 OpenPGP: id=A79F86A8 Content-Type: multipart/mixed; boundary="------------090801050909010403070409" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: Crypto Review X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2009 20:36:49 -0000 This is a multi-part message in MIME format. --------------090801050909010403070409 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 > The Mercurial code is not up to date with the GRUB2 trunk, but is only missing > a minor addition to the new crypto code. I've created a tarball[1] of the > latest code if that helps. > Thanks a lot! I'll check that out tomorrow. I've worked with your patch for a few days now, and it worked very well so far. I used sha256 and ripemd160 functions alone, and also a simple LUKS setup, all without any trouble at all. However, my compiler complains with a lot of warnings, mostly from signdness differences between types and unused results. Is it a normal behaviour? -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkqLEM4ACgkQBV7eXqefhqjASQCgl6L2o8anRT/JX2JcZf65oXpR gSUAn2zLYTOA+KNGBpf6BAPC3hlDSZHm =K+dr -----END PGP SIGNATURE----- --------------090801050909010403070409 Content-Type: text/plain; name="warn.log" Content-Disposition: inline; filename="warn.log" Content-Transfer-Encoding: quoted-printable crypto/crypto.c:40: warning: no previous prototype for =91print_buffer=92 crypto/crypto.c: In function =91print_buffer=92: crypto/crypto.c:43: warning: format not a string literal and no format ar= guments crypto/crypto.c: In function =91grub_crypto_encrypt=92: crypto/crypto.c:207: warning: unused parameter =91outsize=92 crypto/crypto.c: In function =91grub_crypto_decrypt=92: crypto/crypto.c:231: warning: unused parameter =91outsize=92 crypto/crypto.c: In function =91grub_cmd_hash=92: crypto/crypto.c:364: warning: comparison between signed and unsigned crypto/crypto.c:346: warning: unused parameter =91state=92 crypto/crypto.c: In function =91grub_mod_init=92: crypto/crypto.c:379: warning: passing argument 2 of =91grub_register_comm= and=92 from incompatible pointer type crypto/crypto.c: In function =91grub_mod_fini=92: crypto/crypto.c:386: warning: passing argument 1 of =91grub_unregister_co= mmand=92 from incompatible pointer type crypto/ripemd160.c: In function =91grub_hash_rmd160_fn=92: crypto/ripemd160.c:539: warning: unused parameter =91params=92 crypto/md5.c: In function =91grub_hash_md5_fn=92: crypto/md5.c:326: warning: unused parameter =91params=92 crypto/sha1.c: In function =91grub_hash_sha1_fn=92: crypto/sha1.c:337: warning: unused parameter =91params=92 crypto/sha256.c: In function =91grub_hash_sha256_fn=92: crypto/sha256.c:291: warning: unused parameter =91params=92 crypto/sha512.c: In function =91grub_hash_sha512_fn=92: crypto/sha512.c:344: warning: unused parameter =91params=92 crypto/aes.c: In function =91do_setkey=92: crypto/aes.c:162: warning: comparison between signed and unsigned crypto/aes.c: In function =91grub_cipher_aes_decrypt_block=92: crypto/aes.c:718: warning: passing argument 2 of =91rijndael_decrypt=92 f= rom incompatible pointer type crypto/aes.c:718: warning: passing argument 3 of =91rijndael_decrypt=92 f= rom incompatible pointer type crypto/aes.c: In function =91grub_cipher_aes_encrypt_block=92: crypto/aes.c:725: warning: passing argument 2 of =91rijndael_encrypt=92 f= rom incompatible pointer type crypto/aes.c:725: warning: passing argument 3 of =91rijndael_encrypt=92 f= rom incompatible pointer type crypto/cast5.c: In function =91grub_cipher_cast5_set_key=92: crypto/cast5.c:634: warning: pointer targets in passing argument 2 of =91= cast_setkey=92 differ in signedness crypto/cast5.c: In function =91grub_cipher_cast5_decrypt_block=92: crypto/cast5.c:641: warning: pointer targets in passing argument 2 of =91= decrypt_block=92 differ in signedness crypto/cast5.c:641: warning: pointer targets in passing argument 3 of =91= decrypt_block=92 differ in signedness crypto/cast5.c: In function =91grub_cipher_cast5_encrypt_block=92: crypto/cast5.c:648: warning: pointer targets in passing argument 2 of =91= encrypt_block=92 differ in signedness crypto/cast5.c:648: warning: pointer targets in passing argument 3 of =91= encrypt_block=92 differ in signedness crypto/serpent.c: In function =91serpent_key_prepare=92: crypto/serpent.c:583: warning: comparison between signed and unsigned crypto/twofish.c:704: warning: return type defaults to =91int=92 crypto/twofish.c:703: warning: no previous prototype for =91twofish_setke= y=92 crypto/twofish.c: In function =91grub_cipher_twofish_set_key=92: crypto/twofish.c:1049: warning: pointer targets in passing argument 2 of = =91twofish_setkey=92 differ in signedness crypto/twofish.c: In function =91grub_cipher_twofish_decrypt_block=92: crypto/twofish.c:1056: warning: pointer targets in passing argument 2 of = =91twofish_decrypt=92 differ in signedness crypto/twofish.c:1056: warning: pointer targets in passing argument 3 of = =91twofish_decrypt=92 differ in signedness crypto/twofish.c: In function =91grub_cipher_twofish_encrypt_block=92: crypto/twofish.c:1063: warning: pointer targets in passing argument 2 of = =91twofish_encrypt=92 differ in signedness crypto/twofish.c:1063: warning: pointer targets in passing argument 3 of = =91twofish_encrypt=92 differ in signedness disk/luks.c: In function =91grub_read_password=92: disk/luks.c:122: warning: format not a string literal and no format argum= ents disk/luks.c:126: warning: comparison between signed and unsigned disk/luks.c: In function =91print_buffer=92: disk/luks.c:153: warning: format not a string literal and no format argum= ents disk/luks.c: In function =91luks_decrypt=92: disk/luks.c:397: warning: pointer targets in passing argument 2 of =91gru= b_crypto_encrypt=92 differ in signedness disk/luks.c:397: warning: pointer targets in passing argument 3 of =91gru= b_crypto_encrypt=92 differ in signedness disk/luks.c: In function =91grub_luks_open=92: disk/luks.c:507: warning: implicit declaration of function =91grub_env_ge= t=92 disk/luks.c:507: warning: assignment makes pointer from integer without a= cast disk/luks.c:507: warning: suggest parentheses around assignment used as t= ruth value disk/luks.c: In function =91grub_cmd_devmap=92: disk/luks.c:947: warning: implicit declaration of function =91grub_cmdlin= e_get=92 disk/luks.c: At top level: disk/luks.c:977: warning: function declaration isn=92t a prototype disk/luks.c:853: warning: =91grub_cmd_devmap=92 defined but not used disk/devmapper.c: In function =91grub_mod_init=92: disk/devmapper.c:407: warning: passing argument 2 of =91grub_register_com= mand=92 from incompatible pointer type disk/devmapper.c: In function =91grub_mod_fini=92: disk/devmapper.c:413: warning: passing argument 1 of =91grub_unregister_c= ommand=92 from incompatible pointer type --------------090801050909010403070409--