Re: revisit the super page support in HVM restore

["Zhai, Edwin" <edwin.zhai@intel.com>]

Keir Fraser wrote:
> On 19/08/2009 08:08, "Zhai, Edwin" <edwin.zhai@intel.com> wrote:
>
>   
>> So how about this new method:
>> * Not tracking each of pfn inside 2M page, but trying best to allocate
>>   2M pages if the 2M page covering this pfn is not allocated.
>> * There may be holes inside new allocated 2M pages that are not synced in
>>   this batch, but we don't care and assume these missing pfns will
>>   come in future.
>>
>> This new method is simple as the super page support for PV guest is
>> already there.
>>     
>
> You wil fail to restore a guest which has ballooned down its memory as there
> will be 4k holes in its memory map. 

I see. But current PV guest has same issue also. If set superpages for 
the PV guest, allocate_mfn in xc_domain_restore.c would try to allocate 
2M page for each of pfn regardless of the holes. Per my understanding, 
this is more serious issue for PV guest, as it uses balloon driver more 
frequently.

If we have to use this algorithm, back to my complicated code -- do you 
have any suggestion to simplify the logic?

Thanks,


> You will allocate 2MB superpages despite
> these holes, which do not get fixed up until end of restore process, and run
> out of memory in the host, or against the guest's maxmem limit.
>
>  -- Keir
>
>
>   

-- 
best rgds,
edwin