Re: [PATCH] x86 emulator: Add 'push/pop sreg' instructions

[Avi Kivity <avi@redhat.com>]

On 08/18/2009 10:40 PM, Mohammed Gamal wrote:
>>
>>> +       kvm_x86_ops->set_segment(ctxt->vcpu,&segment, seg);
>>>
>>>        
> But we're popping the contents of the stack top to a segment register
> which is going to be of 16-bits anyway, so we know the length before
> hand, no?
>    

No, the operand size attribute determines the change to rsp.  If it's 
larger than 2 bytes we drop the excess bits.  See the documentation of 
the POP instruction.

>> Note some of these instructions are not encodable in long mode; need to
>> check for that instead of emulating the wrong instruction.
>>      
> I was under the impression that the emulator doesn't support long mode
> yet, is that still the case?
>    

The emulator has always supported long mode, we need it for mmio and 
pagetable updates.

-- 
error compiling committee.c: too many arguments to function