From: Gerd Hoffmann <kraxel@redhat.com>
To: Juan Quintela <quintela@trasno.org>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 5/8] ide: split away ide-macio.c
Date: Wed, 19 Aug 2009 15:05:17 +0200 [thread overview]
Message-ID: <4A8BF88D.9020302@redhat.com> (raw)
In-Reply-To: <m34os4qfv2.fsf@neno.mitica>
On 08/19/09 12:04, Juan Quintela wrote:
> Reviewed-by: Juan Quintela<quintela@redhat.com>
>
> Reply-to: quintela@redhat.com
> Gerd Hoffmann<kraxel@redhat.com> wrote:
>> create ide-macio.c and place macio support there.
>> only build ide-macio support for platforms using it.
>
> This patches does two things.
>
> split ide-macio.c
> Move losts of constants from ide.c to ide-internal.h
>
> I agree with both changes, just noticing that they are doing two things
> here. Consider to split the changeset if you have to resend the series
> for any reason. I like the change :)
I've moved things from ide.c to ide-internal.h as needed. Probably
better to have a separate patch which creates the final ide-internal.h
version instead, will fix for the next version (and also the comments ...).
cheers,
Gerd
next prev parent reply other threads:[~2009-08-19 13:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-18 16:06 [Qemu-devel] [PATCH 0/8] ide: cleanup and splitting Gerd Hoffmann
2009-08-18 16:06 ` [Qemu-devel] [PATCH 1/8] ide: add IDEBus struct, cleanups Gerd Hoffmann
2009-08-19 9:49 ` [Qemu-devel] " Juan Quintela
2009-08-18 16:06 ` [Qemu-devel] [PATCH 2/8] ide: split away ide-isa.c Gerd Hoffmann
2009-08-19 9:53 ` [Qemu-devel] " Juan Quintela
2009-08-18 16:06 ` [Qemu-devel] [PATCH 3/8] ide: add save/restore support for isa Gerd Hoffmann
2009-08-18 16:06 ` [Qemu-devel] [PATCH 4/8] ide: split away ide-pci.c Gerd Hoffmann
2009-08-18 16:06 ` [Qemu-devel] [PATCH 5/8] ide: split away ide-macio.c Gerd Hoffmann
[not found] ` <m34os4qfv2.fsf@neno.mitica>
2009-08-19 13:05 ` Gerd Hoffmann [this message]
2009-08-18 16:06 ` [Qemu-devel] [PATCH 6/8] ide: split away ide-mmio.c Gerd Hoffmann
2009-08-18 16:06 ` [Qemu-devel] [PATCH 7/8] ide: add save/restore support for mmio Gerd Hoffmann
2009-08-19 10:07 ` [Qemu-devel] " Juan Quintela
2009-08-18 16:06 ` [Qemu-devel] [PATCH 8/8] ide: split away ide-microdrive.c Gerd Hoffmann
2009-08-18 17:08 ` [Qemu-devel] [PATCH 0/8] ide: cleanup and splitting Avi Kivity
2009-08-19 6:37 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A8BF88D.9020302@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@trasno.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.