From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm:kirkwood Wait for the link to come up on kirkwood network init
Date: Wed, 19 Aug 2009 12:29:12 -0700 [thread overview]
Message-ID: <4A8C5288.5020308@gmail.com> (raw)
In-Reply-To: <20090819192510.BD75D833DBD2@gemini.denx.de>
Wolfgang Denk wrote:
> Dear Ben Warren,
>
>
<snip>
>
>>> + /* Wait up to 5s for the link status */
>>> + for (i = 0; i < 5; i++) {
>>> + u16 phyadr;
>>>
>>>
>> Please put this variable declaration outside of the 'for' loop
>>
>
> Why? If it's only used in this block it's actually a good thing to
> restrict it to this scope.
>
>
It seems your coding standards have changed, which everybody knows is
impossible. Where's you put the old Wolfgang, doppleganger? :)
> Best regards,
>
> Wolfgang Denk
>
>
regards,
Ben
next prev parent reply other threads:[~2009-08-19 19:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-19 10:24 [U-Boot] [PATCH] arm:kirkwood Wait for the link to come up on kirkwood network init Simon Kagstrom
2009-08-19 17:08 ` Ben Warren
2009-08-19 19:25 ` Wolfgang Denk
2009-08-19 19:29 ` Ben Warren [this message]
2009-08-19 19:40 ` Wolfgang Denk
2009-08-20 7:51 ` Simon Kagstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A8C5288.5020308@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.