Re: libata: waiting for the drives to settle

[Jeff Garzik <jeff@garzik.org>]

On 08/20/2009 05:40 AM, Andrei Martynov wrote:
> Hi,
>
> what would be the right place in modern pata driver to implement the
> following old code from function do_probe() in ide-probe.c ?
>
> /*
>   *  ColdFire platforms boot up so quick that most hard drives
>   *  have not completed there own self tests. Pause here for
>   *  a couple of seconds if it looks like there is a drive
>   *  present...
>   */
> if (IN_BYTE(IDE_SELECT_REG) != drive->select.all) {
>    printk("IDE: waiting for drives to settle...\n");
>    for (rc = 0; (rc<  400); rc++) {
>      SELECT_DRIVE(hwif,drive);
>      ide_delay_50ms();
>      if (IN_BYTE(IDE_SELECT_REG) == drive->select.all)
>       break;
>   }
> }
>
> It has to be executed once, so placing it into command handler is
> probably not the right solution.

Have you verified this is needed, under libata?  We already have several 
waits...

	Jeff