From: "H. Peter Anvin" <hpa@zytor.com>
To: "Wang, Shane" <shane.wang@intel.com>
Cc: Ingo Molnar <mingo@elte.hu>,
"Cihula, Joseph" <joseph.cihula@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"arjan@linux.intel.com" <arjan@linux.intel.com>,
"andi@firstfloor.org" <andi@firstfloor.org>,
"chrisw@sous-sol.org" <chrisw@sous-sol.org>,
"jmorris@namei.org" <jmorris@namei.org>,
"jbeulich@novell.com" <jbeulich@novell.com>,
"peterm@redhat.com" <peterm@redhat.com>,
"Wei, Gang" <gang.wei@intel.com>
Subject: Re: [RFC v6][PATCH 2/4] intel_txt: Intel(R) TXT reboot/halt shutdown support
Date: Thu, 20 Aug 2009 09:05:17 -0700 [thread overview]
Message-ID: <4A8D743D.6000504@zytor.com> (raw)
In-Reply-To: <037F493892196B458CD3E193E8EBAD4F01EC3AB3B2@pdsmsx502.ccr.corp.intel.com>
On 08/20/2009 02:33 AM, Wang, Shane wrote:
> Hi Ingo & hpa,
>
> I have made some change on the previous tboot patch to fix the build errors.
> Please comment.
>
> Thanks.
> Shane
>
This code addresses the build errors, but not in the right manner.
We should not have to have tboot-specific #ifdefs in tons and tons of
arch-generic files; we need to figure out how to move them into code
flow already in arch-specific code, or we need to very carefully figure
out what additional arch-specific operations are needed at a higher level.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2009-08-20 16:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 2:31 [RFC v6][PATCH 2/4] intel_txt: Intel(R) TXT reboot/halt shutdown support Joseph Cihula
2009-08-17 15:40 ` Ingo Molnar
2009-08-17 15:53 ` Ingo Molnar
2009-08-20 9:33 ` Wang, Shane
2009-08-20 16:05 ` H. Peter Anvin [this message]
2009-08-20 16:10 ` Andi Kleen
2009-08-21 13:03 ` [PATCH] txt: fix the build errors on non-X86 platforms Shane Wang
2009-08-21 13:50 ` Ingo Molnar
2009-08-21 15:23 ` [PATCH] intel_txt: fix the build errors of intel_txt patch " Shane Wang
2009-08-21 16:12 ` Ingo Molnar
2009-08-21 17:23 ` H. Peter Anvin
2009-08-24 8:20 ` Wang, Shane
2009-08-24 8:48 ` Ingo Molnar
2009-08-26 6:51 ` Shane Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A8D743D.6000504@zytor.com \
--to=hpa@zytor.com \
--cc=andi@firstfloor.org \
--cc=arjan@linux.intel.com \
--cc=chrisw@sous-sol.org \
--cc=gang.wei@intel.com \
--cc=jbeulich@novell.com \
--cc=jmorris@namei.org \
--cc=joseph.cihula@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterm@redhat.com \
--cc=shane.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.