All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@amd.com>
To: Jamie Lokier <jamie@shareable.org>
Cc: Avi Kivity <avi@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] push CPUID level to 4 to allow Intel multicore decoding
Date: Thu, 20 Aug 2009 23:35:07 +0200	[thread overview]
Message-ID: <4A8DC18B.6070500@amd.com> (raw)
In-Reply-To: <20090820193023.GD6066@shareable.org>

Jamie Lokier wrote:
> Andre Przywara wrote:
>> The other option would be to push the level only to four if we use more 
>> than one thread or core.
>>
>> In my research it turned out that Intel pushed the level beyond 4
>> with Pentium4 Prescott (probably with the introduction of real dual
>> core chips to differentiate threads and cores), so this is quite
>> some time ago.
> 
> Pentium 4 wasn't that long ago, from a point of view of running legacy
> guests.
Well, but long enough to get those software issues ruled out. If any 
serious OS would have had problems, somebody would have noticed and 
fixed it.

> I see quite a lot of code in Linux (to pick an example - presumably
> also other OSes) which checks for things by looking at model and
> family number, so I wonder if it's wise to depart a long way from
> CPUIDs which resemble real hardware which has existed.
Yeah, but most of the stuff Linux checks are bugs and workarounds, so I 
am not 100% sure whether it's an advantage. We should be careful with 
adjusting the working default QEMU/KVM has right now.

> We've already seen a problem along these lines, which was the x86
> CPUID_SEP feature not getting used properly, but that was quite well
> hidden, only affecting one application (Skype) on Windows.
> 
> Could it make more sense to, in effect, upgrade the default CPUID
> to Pentium 4 (instead of Pentium Pro) when cores > 1?
OK, OK, I will finally send this patch out (following in another mail).
This is a kvm64 CPU (which should become the new KVM's default, if it 
proves to work well). It looks like a P4 Prescott, that seems to be a 
good base, since it has a decent base line of features and is among the 
first CPUs which are supported by KVM.
If someone has such a real beast (best would be a Pentium 4 662 or other 
Prescotts with x86_64, HT and VT-x), I would love to see a complete 
CPUID dump (including the 0000_0004 subleafs, which x86info omits).

Regards,
Andre.

-- 
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
Tel: +49 351 488-3567-12
----to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Jochen Polster; Thomas M. McCoy; Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

  reply	other threads:[~2009-08-20 21:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-19 13:42 [Qemu-devel] [PATCH 0/3]: Introduce multi-core and multi-thread support for guests Andre Przywara
2009-08-19 13:42 ` [Qemu-devel] [PATCH 1/3] extend -smp parsing to include cores= and threads= options Andre Przywara
2009-08-19 13:42 ` [Qemu-devel] [PATCH 2/3] push CPUID level to 4 to allow Intel multicore decoding Andre Przywara
2009-08-20 10:06   ` Avi Kivity
2009-08-20 10:36     ` Andre Przywara
2009-08-20 11:06       ` Avi Kivity
2009-08-20 19:03         ` [Qemu-devel] [PATCH] allow overriding of CPUID level on command line Andre Przywara
2009-08-25 12:21         ` [Qemu-devel] [PATCH 2/3] push CPUID level to 4 to allow Intel multicore decoding Andre Przywara
2009-08-20 19:30       ` Jamie Lokier
2009-08-20 21:35         ` Andre Przywara [this message]
2009-08-19 13:42 ` [Qemu-devel] [PATCH 3/3] set CPUID bits to present cores and threads topology Andre Przywara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A8DC18B.6070500@amd.com \
    --to=andre.przywara@amd.com \
    --cc=avi@redhat.com \
    --cc=jamie@shareable.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.