All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <bonzini@gnu.org>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 03/14] configure stellaris device only for arm softmmu
Date: Fri, 21 Aug 2009 10:52:43 +0200	[thread overview]
Message-ID: <4A8E605B.4050807@gnu.org> (raw)
In-Reply-To: <8321db3e7d3b04a58a07b77256f5c11fad54c1dd.1250810973.git.quintela@redhat.com>


>   # What drivers should we compile
>   ssi_bus=no
> +stellaris=no

What about calling these CONFIG_SSI CONFIG_STELLARIS etc. already in 
configure, and initializing them with

: ${CONFIG_SSI=n}
: ${CONFIG_STELLARIS=n}

> @@ -2236,6 +2238,10 @@ if test "$ssi_bus" = "yes" ; then
>       echo "CONFIG_SSI=y">>  $config_host_mak
>   fi
>
> +if test "$stellaris" = "yes" ; then
> +    echo "CONFIG_STELLARIS=y">>  $config_host_mak
> +fi

Then you can:

1) save duplication using

for i in CONFIG_SSI CONFIG_STELLARIS; do
   case \$$i in
   if test "$config_var" = y; then
     echo "$i=y">> $config_host_mak
   fi
done

2) allow the user to force your choice by setting environment variables 
when calling configure (not sure how useful this is).

Otherwise, looks nice!

Paolo

  reply	other threads:[~2009-08-21  8:52 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-20 23:36 [Qemu-devel] [PATCH 00/14] Compile only devices that are used Juan Quintela
2009-08-20 23:37 ` [Qemu-devel] [PATCH 01/14] Generate config-host.h after dealing with all the targets Juan Quintela
2009-08-20 23:37 ` [Qemu-devel] [PATCH 02/14] Configure ssi bus and devices only if arm-softmmu target is selected Juan Quintela
2009-08-20 23:37 ` [Qemu-devel] [PATCH 03/14] configure stellaris device only for arm softmmu Juan Quintela
2009-08-21  8:52   ` Paolo Bonzini [this message]
2009-08-21  9:11     ` [Qemu-devel] " Juan Quintela
2009-08-20 23:37 ` [Qemu-devel] [PATCH 04/14] configure nseries devices " Juan Quintela
2009-08-20 23:37 ` [Qemu-devel] [PATCH 05/14] configure spitz " Juan Quintela
2009-08-20 23:37 ` [Qemu-devel] [PATCH 06/14] configure sd flash " Juan Quintela
2009-08-20 23:37 ` [Qemu-devel] [PATCH 07/14] configure ptimer only for arm and sparc softmmu Juan Quintela
2009-08-21 19:51   ` Blue Swirl
2009-08-24 11:32     ` [Qemu-devel] " Juan Quintela
2009-08-20 23:37 ` [Qemu-devel] [PATCH 08/14] configure m48t59 only for sparc* and ppc softmmu Juan Quintela
2009-08-20 23:37 ` [Qemu-devel] [PATCH 09/14] configure escc only for sparc " Juan Quintela
2009-08-20 23:37 ` [Qemu-devel] [PATCH 10/14] configure esp only for mips_jazz and sparc softmmu Juan Quintela
2009-08-20 23:37 ` [Qemu-devel] [PATCH 11/14] configure ecc flash only for arm " Juan Quintela
2009-08-20 23:37 ` [Qemu-devel] [PATCH 12/14] configure nand flash only for arm and chris softmmu Juan Quintela
2009-08-20 23:37 ` [Qemu-devel] [PATCH 13/14] configure qdev-addr.o only for sparc softmmu Juan Quintela
2009-08-20 23:37 ` [Qemu-devel] [PATCH 14/14] compile isa_mmio.o only for the platforms that use it Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A8E605B.4050807@gnu.org \
    --to=bonzini@gnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.