[Qemu-devel] Re: [PATCH 21/23] Port PCIDevice state to VMState

[Gerd Hoffmann <kraxel@redhat.com>]

On 08/21/09 11:01, Juan Quintela wrote:
> I agree that the INT32_EQUAL is a bad idea. But that is how
> the current code is done.

Consider changing the code then ;)

>> Beside that we'll have to think about how to handle versioning of
>> structs.  Do we want vmstate_pci_device (and all others) have its own
>> version?  Probably makes sense.  Handling this should go into the
>> generic code then and not be hacked into each structure using
>> VMSTATE_INT32_LE().
>
> Proper solution here is to use subsections.
> Each time that you call VMSTATE_PCI_DEVICE() it sends a subsection
> there.  Then we get the versioning by free.  This is how I am thinking
> it is the right way to do it.

Yep, something like this.

> virtio stuff: the more than I think about it, the easier way is to just
> get rid of the whole mess and do something that is sensible.

You are talking about VirtIOPCIProxy I guess?
Yea, that is messy ...

cheers,
   Gerd