From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Lalancette Subject: Re: [PATCH]: Implement bzip2 and LZMA loaders / fixed patch for Xen 3.4.1 Date: Fri, 21 Aug 2009 11:42:46 +0200 Message-ID: <4A8E6C16.1030908@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org Keir Fraser wrote: > On 21/08/2009 10:22, "Pasi K=E4rkk=E4inen" wrote: >=20 >>> Okay, I tested and fixed the stubdom case, so hopefully c/s 20104 wil= l >>> actually work for you. >>> >> xen-unstable "make tools && make stubdom" compiles for me with and wit= hout >> libbz2-devel/liblzma-devel installed. >> >> But even when I have liblzma-devel installed it doesn't seem to use it= . >> ie. I only see -DHAVE_BZLIB in the build log and libxenguest.so.3.4.0 = gets >> only linked against -lbz2. >> >> Investigating more.. >=20 > With that package installed, do you have a header /usr/include/lzma.h, = or > otherwise have lzma.h on the standard include path? If not then we're d= oing > the right thing, since Chris's patch wants to #include . If it = is, > then the has_header lzma.h check in the libxc Makefile is broken someho= w. Hm, there's also a somewhat confusing situation with LZMA. I'm not sure = I completely understand it, but from what I can tell the lzma.h header file= should be coming from the new "xz" project, not from the lzma project. That is,= on my Fedora 10 box, in order to get LZMA support compiled, I needed to install= the xz-devel package; lzma-devel was not sufficient. --=20 Chris Lalancette