All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Mark Lord <liml@rtr.ca>
Cc: Robert Hancock <hancockrwd@gmail.com>,
	ide <linux-ide@vger.kernel.org>, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH #upstream] sata_sil24: always set protocol override for non-ATAPI data commands
Date: Sat, 22 Aug 2009 12:10:25 -0400	[thread overview]
Message-ID: <4A901871.7020206@garzik.org> (raw)
In-Reply-To: <4A900E87.5060207@rtr.ca>

On 08/22/2009 11:28 AM, Mark Lord wrote:
> Mmm.. I wonder if something like this patch might also be applicable
> to the sata_sil.c driver too?


Not AFAICT.  The 3112 has a Command Protocol Table inside the chip. 
Each command reads the ATA command protocol from that table.  The table 
is programmable (see section 10.3 of [1]), but not on a per-command 
basis.  The per-command PRD format is pretty much legacy IDE[2], and 
nothing like the modern FIS-based controllers.

	Jeff



[1] http://gkernel.sourceforge.net/specs/sii/3112A_SiI-DS-0095-B2.pdf.bz2
[2] bmdma2 modifies the PRD format a bit, but it is not relevant to this 
thread

  reply	other threads:[~2009-08-22 16:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-30 20:11 [PATCH #upstream] sata_sil24: always set protocol override for non-ATAPI data commands Robert Hancock
2009-07-30 20:18 ` Mark Lord
2009-07-30 20:53 ` Jeff Garzik
2009-07-31  1:20   ` Tejun Heo
2009-08-22  5:57 ` Robert Hancock
2009-08-22 14:03   ` Mark Lord
2009-08-22 14:11     ` Jeff Garzik
2009-08-22 15:25       ` Mark Lord
2009-08-22 15:28         ` Mark Lord
2009-08-22 16:10           ` Jeff Garzik [this message]
2009-08-22 16:27             ` Robert Hancock
2009-08-22 16:02         ` Jeff Garzik
2009-08-22 16:30       ` Robert Hancock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A901871.7020206@garzik.org \
    --to=jeff@garzik.org \
    --cc=hancockrwd@gmail.com \
    --cc=liml@rtr.ca \
    --cc=linux-ide@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.