From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: "Xu, Jiajun" <jiajun.xu@intel.com>, "'kvm-devel'" <kvm@vger.kernel.org>
Subject: Re: KVM: PIT: fix pit_state copy in set_pit2/get_pit2
Date: Tue, 25 Aug 2009 15:33:02 +0300 [thread overview]
Message-ID: <4A93D9FE.8080906@redhat.com> (raw)
In-Reply-To: <20090825122921.GA18813@amt.cnet>
On 08/25/2009 03:29 PM, Marcelo Tosatti wrote:
> The kvm_pit_state2 structure contains extra space, so the memcpy
> in kvm_vm_ioctl_set_pit2 corrupts kvm->arch.vpit->pit_state.
>
> Fix it by memcpy'ing the channel information and assigning flags
> manually.
>
Good catch; applied.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-08-25 12:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-17 1:32 Biweekly KVM Test report, kernel 7597f... qemu 1c45e Xu, Jiajun
2009-08-17 12:17 ` Avi Kivity
2009-08-19 2:14 ` Xu, Jiajun
2009-08-19 8:08 ` Avi Kivity
2009-08-21 7:14 ` Xu, Jiajun
2009-08-25 10:20 ` Avi Kivity
2009-08-25 12:29 ` KVM: PIT: fix pit_state copy in set_pit2/get_pit2 Marcelo Tosatti
2009-08-25 12:33 ` Avi Kivity [this message]
2009-08-27 1:23 ` Xu, Jiajun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A93D9FE.8080906@redhat.com \
--to=avi@redhat.com \
--cc=jiajun.xu@intel.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.