From: Warren Togami <wtogami-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Victor Lowther
<victor.lowther-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
initramfs <initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 19/18] Modify nbd hostonly checking to use check_block_and_slaves.
Date: Tue, 25 Aug 2009 11:00:34 -0400 [thread overview]
Message-ID: <4A93FC92.1010305@redhat.com> (raw)
In-Reply-To: <1a4c4015bc85feeb9fbf95a9d1e9adfb2de8e897.1250465033.git.victor.lowther-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On 08/16/2009 07:24 PM, Victor Lowther wrote:
> +# if an nbd device is not somewhere in the chain of devices root is mounted on,
> +# fail the hostonly check.
> +[ "$1" = "-h" ]&& {
> + rootdev=$(find_root_block_device)
> + [[ -b /dev/block/$rootdev ]] || exit 1
> + check_block_and_slaves is_nbd "$rootdev" || exit 1
> +}
When will this ever work? More often than not you would be generating a
netboot in a chroot of the image. You almost never generate the initrd
on the running netbooted system.
Warren Togami
wtogami-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-08-25 15:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-16 23:24 [PATCH 19/18] Modify nbd hostonly checking to use check_block_and_slaves Victor Lowther
[not found] ` <1a4c4015bc85feeb9fbf95a9d1e9adfb2de8e897.1250465033.git.victor.lowther-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-08-25 15:00 ` Warren Togami [this message]
[not found] ` <4A93FC92.1010305-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-08-25 16:52 ` Victor Lowther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A93FC92.1010305@redhat.com \
--to=wtogami-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=victor.lowther-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.