From: Jeff Garzik <jeff@garzik.org>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Project Hail List <hail-devel@vger.kernel.org>
Subject: Re: [Patch] cld: pad protocol structures
Date: Wed, 26 Aug 2009 02:25:29 -0400 [thread overview]
Message-ID: <4A94D559.8060004@garzik.org> (raw)
In-Reply-To: <20090825183740.24cbc72d@redhat.com>
On 08/25/2009 08:37 PM, Pete Zaitcev wrote:
> As it turned out, sizeof produces different results on 64-bit and
> 32-bit hosts because the size of the structure may aligned on whatever
> biggest alignment the gcc decides appropriate. It's not necesserily
> the biggest type, as on RISCs and Itanium, where accessing arrays
> of structs with misaligned sizeof will cause SIGBUS. As a result,
> our structs varied in size despite using fixed-size types.
>
> Our preferred fix is to pad structures so that they become more
> portable.
>
> This patch creates a flag day on 32-bit systems (but not on 64-bit
> ones). CLD clients and the daemon must be rebuilt.
>
> Signed-Off-By: Pete Zaitcev<zaitcev@redhat.com>
applied
prev parent reply other threads:[~2009-08-26 6:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-26 0:37 [Patch] cld: pad protocol structures Pete Zaitcev
2009-08-26 6:25 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A94D559.8060004@garzik.org \
--to=jeff@garzik.org \
--cc=hail-devel@vger.kernel.org \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.