From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752926AbZHZTIp (ORCPT ); Wed, 26 Aug 2009 15:08:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752864AbZHZTIp (ORCPT ); Wed, 26 Aug 2009 15:08:45 -0400 Received: from hera.kernel.org ([140.211.167.34]:57467 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752837AbZHZTIo (ORCPT ); Wed, 26 Aug 2009 15:08:44 -0400 Message-ID: <4A9587FE.20503@kernel.org> Date: Wed, 26 Aug 2009 12:07:42 -0700 From: Yinghai Lu User-Agent: Thunderbird 2.0.0.22 (X11/20090605) MIME-Version: 1.0 To: Suresh Siddha CC: Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , "linux-kernel@vger.kernel.org" , Cyrill Gorcunov Subject: Re: [PATCH] x86: use hard_smp_processor_id to get apic id in identify_cpu -v2 References: <4A9391CD.5020804@kernel.org> <4A946082.9090809@kernel.org> <1251240835.2636.28.camel@sbs-t61> <4A948C88.9060403@kernel.org> <1251308988.2787.39.camel@sbs-t61.sc.intel.com> In-Reply-To: <1251308988.2787.39.camel@sbs-t61.sc.intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Suresh Siddha wrote: > > In short, on all the platforms we want to use initial apic id for apicid > and phys_proc_id. And only on the required platforms like x445, vsmp, > some AMD platforms, we can have their own mechanisms. > >> 3. for vsmp, and x445, do you want to have c->apicid to have real apic id or the same as initial apic_id? > > On these platforms, c->apicid should be based on their real apic id. > >> this patch is trying to make c->apicid to have real apic_id. > > Can you please modify the patch so that we can have exceptions for > needed platforms only? > please check this one [PATCH] x86: use hard_smp_processor_id to get apic id for amd k8 cpus otherwise, system with apci id lifting will have wrong apicid in /proc/cpuinfo and use that in srat_detect_node Signed-off-by: Yinghai Lu --- arch/x86/kernel/cpu/amd.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) Index: linux-2.6/arch/x86/kernel/cpu/amd.c =================================================================== --- linux-2.6.orig/arch/x86/kernel/cpu/amd.c +++ linux-2.6/arch/x86/kernel/cpu/amd.c @@ -277,7 +277,7 @@ static void __cpuinit srat_detect_node(s #if defined(CONFIG_NUMA) && defined(CONFIG_X86_64) int cpu = smp_processor_id(); int node; - unsigned apicid = cpu_has_apic ? hard_smp_processor_id() : c->apicid; + unsigned apicid = c->apicid; node = c->phys_proc_id; if (apicid_to_node[apicid] != NUMA_NO_NODE) @@ -437,6 +437,9 @@ static void __cpuinit init_amd(struct cp } if (c->x86 == 0x10 || c->x86 == 0x11) set_cpu_cap(c, X86_FEATURE_REP_GOOD); + + /* get apicid instead of initial apic id from cpuid */ + c->apicid = hard_smp_processor_id(); #else /*