From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dirk Behme <dirk.behme@googlemail.com>
Date: Thu, 27 Aug 2009 16:07:57 +0200
Subject: [U-Boot] [RFC] OMAP3: make TWL4030 optional for MMC driver
In-Reply-To: <4A968D39.1030900@windriver.com>
References: <1251379448-29356-1-git-send-email-mludwig@ultratronik.de>
	<4A968D39.1030900@windriver.com>
Message-ID: <4A96933D.7050706@googlemail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Tom wrote:
> Maybe it would be better if the power_init function was removed from the 
> common file and moved to the individual board files.  What do you think ?
> Tom

Yes, sounds like a good idea.

Best regards

Dirk

> Matthias Ludwig wrote:
>> Upcoming boards may power MMC card themself without using
>> TWL4030, so make it optional by using define CONFIG_TWL4030_MMC.
>>
>> Enable this for all existing OMAP3 boards.
>>
>> Signed-off-by: Matthias Ludwig <mludwig@ultratronik.de>
>> ---
>>
>> Current OMAP3 MMC driver does require TWL4030 support to
>> be enabled as all OMAP3 boards are using this chip. I'd like
>> to push patches for a new board which does not has a TWL4030
>> and is caring about MMC power by itself.
>>
>> So, my suggestion is to make the TWL4030 dependency optional.
>> Are there better ways to to this can using a new define
>> CONFIG_TWL4030_MMC?
>>
>>  drivers/mmc/omap3_mmc.c         |    4 ++++
>>  include/configs/omap3_beagle.h  |    1 +
>>  include/configs/omap3_evm.h     |    1 +
>>  include/configs/omap3_overo.h   |    1 +
>>  include/configs/omap3_pandora.h |    1 +
>>  include/configs/omap3_zoom1.h   |    1 +
>>  include/configs/omap3_zoom2.h   |    1 +
>>  7 files changed, 10 insertions(+), 0 deletions(-)
....